refactor clippy in bootstrap #122883
Merged
refactor clippy in bootstrap #122883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rustbot
added
A-testsuite
onur-ozkan
force-pushed
the
clippy-build-step
branch
from
dcaa724
to
006354c
Compare
|
This PR modifies If appropriate, please update |
This comment has been minimized.
This comment has been minimized.
onur-ozkan
added
S-waiting-on-author
onur-ozkan
force-pushed
the
clippy-build-step
branch
2 times, most recently
from
879b09a
to
e6a675c
Compare
|
I was planning to run clippy on bootstrap and various other tools on CI, which means I will need to make some more changes to fix clippy warnings. As it makes this PR difficult to review, I will do that as a follow-up to this PR once it's merged. r? bootstrap |
onur-ozkan
added
S-waiting-on-review
onur-ozkan
changed the title
albertlarsan68
approved these changes
Apr 16, 2024
|
Thanks for the PR! |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 16, 2024
…bertlarsan68 refactor clippy in bootstrap Previously, using clippy in bootstrap was not very useful as explained in rust-lang#122825. In short, regardless of the given path clippy would always check the entire compiler and std tree. This makes it impossible to run clippy on different paths with different set of rules. This PR fixes that by allowing developers to run clippy with specific rules on specific paths (e.g., we can run `x clippy compiler -Aclippy::all -Dclippy::correctness` and `x clippy library/std -Dclippy::all` and none of them will affect each other). Resolves rust-lang#122825
|
probably failing in #124025 (comment) |
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Previously this command was linting compiler and library together. As we no longer run clippy on the entire tree unless it's explicitly requested, we need to update this command by adding `library` path. Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
clippy-build-step
branch
from
e6a675c
to
16cf0e6
Compare
Rebased. @bors r=albertlarsan68 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#122813 (Qualifier tweaking) - rust-lang#122883 (refactor clippy in bootstrap) - rust-lang#123997 (Delay span bug when `Self` kw resolves to `DefKind::{Mod,Trait}`) - rust-lang#124045 (Reinstate nnethercote to the review rotation.) - rust-lang#124051 (Fix empty-set symbol in comments) - rust-lang#124052 (Make the comments for `ReturnDest` variants doc comments) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2024
Rollup merge of rust-lang#122883 - onur-ozkan:clippy-build-step, r=albertlarsan68 refactor clippy in bootstrap Previously, using clippy in bootstrap was not very useful as explained in rust-lang#122825. In short, regardless of the given path clippy would always check the entire compiler and std tree. This makes it impossible to run clippy on different paths with different set of rules. This PR fixes that by allowing developers to run clippy with specific rules on specific paths (e.g., we can run `x clippy compiler -Aclippy::all -Dclippy::correctness` and `x clippy library/std -Dclippy::all` and none of them will affect each other). Resolves rust-lang#122825
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, using clippy in bootstrap was not very useful as explained in #122825. In short, regardless of the given path clippy would always check the entire compiler and std tree. This makes it impossible to run clippy on different paths with different set of rules. This PR fixes that by allowing developers to run clippy with specific rules on specific paths (e.g., we can run
x clippy compiler -Aclippy::all -Dclippy::correctnessandx clippy library/std -Dclippy::alland none of them will affect each other).Resolves #122825