-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
canonicalizer: add lookup table #125495
canonicalizer: add lookup table #125495
Conversation
☔ The latest upstream changes (presumably #126650) made this pull request unmergeable. Please resolve the merge conflicts. |
69b1876
to
f572903
Compare
Some changes occurred in engine.rs, potentially modifying the public API of |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
… r=<try> canonicalizer: add lookup table blocking this on being able to run perf, may be necessary for deeply nested types. r? `@compiler-errors`
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (e56bc53): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary 11.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 20.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 751.027s -> 761.751s (1.43%) |
f572903
to
332098c
Compare
☔ The latest upstream changes (presumably #130821) made this pull request unmergeable. Please resolve the merge conflicts. |
merged as part of #130821 |
blocking this on being able to run perf, may be necessary for deeply nested types.
r? @compiler-errors