-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate more in-tree libs for crates.io #19820
Conversation
This commit deprecates a few more in-tree libs for their crates.io counterparts. Note that this commit does not make use of the #[deprecated] tag to prevent warnings from being generated for in-tree usage. Once #[unstable] warnings are turned on then all external users will be warned to move. These crates have all been duplicated in rust-lang/$crate repositories so development can happen independently of the in-tree copies. We can explore at a later date replacing the in-tree copies with the external copies, but at this time the libraries have changed very little over the past few months so it's unlikely for changes to be sent to both repos. cc rust-lang#19260
Was the decision/discussion for these recorded anywhere? |
This is not an rfc, reviewers will make decision.
|
@gankro I haven't been able to dig up any notes just yet, but in general we're not willing to commit to any library in-tree at this time other than the standard library. As a result we have a large number of useful crates in-tree (such as all of these) which we would still like to provide. By providing these crates in crates.io we get a number of benefits:
Note that this is not just removing these crates. We plan to continue officially supporting them in the |
👍 |
The |
The story of the |
I'm running into a lot of warnings trying to use the out-of-tree versions of these crates. What's the plan for dealing with them? Everything works fine, but it's really noisy.
|
@sfackler are you sure the entire dependency tree is using libregex/liblog from crates.io? We're cutting down the size of the standard distribution to just one crate (the standard library), so you in general shouldn't be receiving those warnings as all crates migrate to crates.io. |
Ah, it's probably coming in through libserialize |
I'm ok with this strategy. |
Deprecate more in-tree libs for crates.io Reviewed-by: aturon
Using a type alias for iterator implementations is fragile since this exposes the implementation to users of the iterator, and any changes could break existing code. This commit changes the iterators of `VecMap` to use proper new types, rather than type aliases. However, since it is fair-game to treat a type-alias as the aliased type, this is a: [breaking-change].
This commit deprecates a few more in-tree libs for their crates.io counterparts. Note that this commit does not make use of the #[deprecated] tag to prevent warnings from being generated for in-tree usage. Once #[unstable] warnings are turned on then all external users will be warned to move. These crates have all been duplicated in rust-lang/$crate repositories so development can happen independently of the in-tree copies. We can explore at a later date replacing the in-tree copies with the external copies, but at this time the libraries have changed very little over the past few months so it's unlikely for changes to be sent to both repos. cc rust-lang#19260
The log crate should be coming from crates.io in the future. See the PR [here](rust-lang/rust#19820).
This commit deprecates a few more in-tree libs for their crates.io counterparts.
Note that this commit does not make use of the #[deprecated] tag to prevent
warnings from being generated for in-tree usage. Once #[unstable] warnings are
turned on then all external users will be warned to move.
These crates have all been duplicated in rust-lang/$crate repositories so
development can happen independently of the in-tree copies. We can explore at a
later date replacing the in-tree copies with the external copies, but at this
time the libraries have changed very little over the past few months so it's
unlikely for changes to be sent to both repos.
cc #19260