Use the sugary syntax to print the Fn traits in error messages
#19912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let did = trait_def.trait_ref.def_id; | ||
| let is_fn_trait = cx.lang_items.fn_trait().map_or(false, |id| id == did) | ||
| || cx.lang_items.fn_mut_trait().map_or(false, |id| id == did) | ||
| || cx.lang_items.fn_once_trait().map_or(false, |id| id == did); |
There was a problem hiding this comment.
Could this logic for is_fn_trait be refactored into the parameterized function? You could just pass in the def_id and it could internally check for these traits.
ftxqxd
force-pushed
the
fn-formatting
branch
from
af4156d to
570325d
Compare
|
@alexcrichton I found out about |
|
Aha, nice catch! |
bors
added a commit
that referenced
this pull request
Dec 17, 2014
Use the sugary syntax to print the `Fn` traits in error messages Reviewed-by: alexcrichton
bors
referenced
this pull request
Dec 17, 2014
Using a type alias for iterator implementations is fragile since this exposes the implementation to users of the iterator, and any changes could break existing code. This commit changes the iterators of `VecMap` to use proper new types, rather than type aliases. However, since it is fair-game to treat a type-alias as the aliased type, this is a: [breaking-change].
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 17, 2014
This is to encourage the use of the sugary syntax instead of the `<>` syntax, which will not be usable post-1.0. Rustdoc [still uses the `<>` syntax](rust-lang#19909), so if a rustdoc wizard is looking for something to do, it would be nice to use the parenthetical syntax there as well. (I tried to patch rustdoc as well, but failed…)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to encourage the use of the sugary syntax instead of the
<>syntax, which will not be usable post-1.0. Rustdoc still uses the<>syntax, so if a rustdoc wizard is looking for something to do, it would be nice to use the parenthetical syntax there as well. (I tried to patch rustdoc as well, but failed…)