Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rust book error-handling.md for new std::io. #23933

Merged
merged 1 commit into from
Apr 2, 2015

Conversation

kgv
Copy link

@kgv kgv commented Apr 1, 2015

Fix example and some text for: read_line takes &mut String and return Result instead IoResult.

r? @steveklabnik

Fix example and some text for: `read_line` takes `&mut String` and return `Result` instead `IoResult`.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Apr 1, 2015

📌 Commit 343c110 has been approved by steveklabnik

@steveklabnik
Copy link
Member

Thank you!

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Apr 1, 2015
Fix example and some text for: `read_line` takes `&mut String` and return `Result` instead `IoResult`.

r? @steveklabnik
@alexcrichton alexcrichton merged commit 343c110 into rust-lang:master Apr 2, 2015
@kgv kgv deleted the kgv_fix branch April 11, 2015 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants