split rustc::metadata to a rustc_metadata crate #30043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🌜 |
|
Yeah, I like this approach here. |
|
this looks good. r=me on the commits so far if we add some kind of comment explaining that |
arielb1
changed the title
|
@bors r=nmatsakis |
|
📌 Commit f617e93 has been approved by |
|
Needs a rebase. |
arielb1
force-pushed
the
split-metadata
branch
from
f617e93
to
2b7b8d1
Compare
|
@bors r=nmatsakis |
|
📌 Commit 2b7b8d1 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 25, 2015
This improves bootstrap times because of better parallelism - though I need to measure how much - and allows metadata to be modified without triggering a full recompile. This also ensures that metadata handling and the rest of rustc remain decoupled, which is a first step for switching to a new metadata format. This is a [breaking-change] to all plugin authors because of the following renames: * `rustc::plugin` is now `rustc_plugin` * `rustc::metadata` is now `rustc_metadata` * Most data types from `rustc::metadata`, along with `LOCAL_CRATE`, are now in `rustc::middle::cstore`. * The CStore methods were split between the `rustc::middle::CrateStore` trait (and trait object) and the `rustc_metadata::cstore::CStore`, with an `Rc<CrateStore>` stored in the `Session`. The inner `CStore` can be accessed via the inner `Any` bound, but this is deprecated. r? @nikomatsakis
|
💔 Test failed - auto-mac-64-nopt-t |
|
☔ The latest upstream changes (presumably #30015) made this pull request unmergeable. Please resolve the merge conflicts. |
rustdoc still broken
this is a [breaking-change] to all plugin authors - sorry
tests & rustdoc still broken
arielb1
force-pushed
the
split-metadata
branch
from
2b7b8d1
to
43a6deb
Compare
|
@bors r=nikomatsakis |
|
📌 Commit 43a6deb has been approved by |
bors
added a commit
that referenced
this pull request
Nov 26, 2015
This improves bootstrap times because of better parallelism - though I need to measure how much - and allows metadata to be modified without triggering a full recompile. This also ensures that metadata handling and the rest of rustc remain decoupled, which is a first step for switching to a new metadata format. This is a [breaking-change] to all plugin authors because of the following renames: * `rustc::plugin` is now `rustc_plugin` * `rustc::metadata` is now `rustc_metadata` * Most data types from `rustc::metadata`, along with `LOCAL_CRATE`, are now in `rustc::middle::cstore`. * The CStore methods were split between the `rustc::middle::CrateStore` trait (and trait object) and the `rustc_metadata::cstore::CStore`, with an `Rc<CrateStore>` stored in the `Session`. The inner `CStore` can be accessed via the inner `Any` bound, but this is deprecated. r? @nikomatsakis
This was referenced Nov 26, 2015
hobofan
added a commit
to hobofan/rust-clippy
that referenced
this pull request
Nov 27, 2015
Fixes brakage introduced by rust-lang/rust#30043
hobofan
added a commit
to hobofan/rust-clippy
that referenced
this pull request
Nov 27, 2015
Fixes breakage introduced by rust-lang/rust#30043
sgrif
added a commit
to sgrif/quasi
that referenced
this pull request
Nov 27, 2015
`rustc::plugin` is now `rustc_plugin`
erickt
added a commit
to serde-deprecated/quasi
that referenced
this pull request
Nov 29, 2015
sgrif
added a commit
to sgrif/quickcheck
that referenced
this pull request
Dec 2, 2015
As of rust-lang/rust#30043, `rustc::plugin` is now `rustc_plugin`.
sgrif
added a commit
to sgrif/quickcheck
that referenced
this pull request
Dec 2, 2015
As of rust-lang/rust#30043, `rustc::plugin` is now `rustc_plugin`.
This was referenced Jan 12, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves bootstrap times because of better parallelism - though I need to measure how much - and allows metadata to be modified without triggering a full recompile. This also ensures that metadata handling and the rest of rustc remain decoupled, which is a first step for switching to a new metadata format.
This is a [breaking-change] to all plugin authors because of the following renames:
rustc::pluginis nowrustc_pluginrustc::metadatais nowrustc_metadatarustc::metadata, along withLOCAL_CRATE, are now inrustc::middle::cstore.rustc::middle::CrateStoretrait (and trait object) and therustc_metadata::cstore::CStore, with anRc<CrateStore>stored in theSession. The innerCStorecan be accessed via the innerAnybound, but this is deprecated.r? @nikomatsakis