Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't leak environment variables into test process #31256

Merged
merged 1 commit into from
Jan 29, 2016

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jan 28, 2016

if the tests were run with RUST_BACKTRACE=1 make check this test failed. If they were run without RUST_BACKTRACE=1 it succeeded.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nagisa
Copy link
Member

nagisa commented Jan 28, 2016

@bors r+ rollup 97be317

@bors
Copy link
Contributor

bors commented Jan 28, 2016

📌 Commit 97be317 has been approved by nagisa

@bors
Copy link
Contributor

bors commented Jan 28, 2016

⌛ Testing commit 97be317 with merge 1d4887e...

@bors
Copy link
Contributor

bors commented Jan 28, 2016

💔 Test failed - auto-win-gnu-64-opt

@nagisa
Copy link
Member

nagisa commented Jan 28, 2016

The failure filled as #31259

@alexcrichton
Copy link
Member

I'd recommend an explicit env_remove instead of clearing all environment variables, that's unlikely to ever work on Windows unfortunately.

If the tests were run with `RUST_BACKTRACE=1 make check` this test failed. If they were run without it it succeeded.
We need to use `env_remove` instead of `env_clear` because the latter will never work on windows
@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 29, 2016

fixed

@nagisa
Copy link
Member

nagisa commented Jan 29, 2016

@bors r+ 5012d20

Manishearth added a commit to Manishearth/rust that referenced this pull request Jan 29, 2016
if the tests were run with `RUST_BACKTRACE=1 make check` this test failed. If they were run without `RUST_BACKTRACE=1` it succeeded.
bors added a commit that referenced this pull request Jan 29, 2016
@bors bors merged commit 5012d20 into rust-lang:master Jan 29, 2016
@oli-obk oli-obk deleted the patch-1 branch January 30, 2016 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants