Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On missing method do not suggest private traits #47534

Merged
merged 1 commit into from
Jan 25, 2018
Merged

On missing method do not suggest private traits #47534

merged 1 commit into from
Jan 25, 2018

Commits on Jan 22, 2018

  1. Do not suggest private traits that have missing method 

    When encountering a method call for an ADT that doesn't have any
implementation of it, we search for traits that could be implemented
that do have that method. Filter out private non-local traits that would
not be able to be implemented.

This doesn't account for public traits that are in a private scope, but
works as a first approximation and is a more correct behavior than the
current one.
    @estebank
    estebank committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    4121ddb View commit details
    Browse the repository at this point in the history