Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Release notes, dist with time crate, and #48092 #48146

Merged
merged 6 commits into from
Feb 12, 2018
Merged

[beta] Release notes, dist with time crate, and #48092 #48146

merged 6 commits into from
Feb 12, 2018

Conversation

Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Feb 11, 2018 •
edited
Loading

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@Mark-Simulacrum Mark-Simulacrum changed the title Release notes and dist with time crate [beta] Release notes and dist with time crate Feb 11, 2018
@Mark-Simulacrum Mark-Simulacrum changed the title [beta] Release notes and dist with time crate [beta] Release notes, dist with time crate, and #48092 Feb 11, 2018
@Mark-Simulacrum
Copy link
Member Author

Note that #48092 has not yet been approved for beta backport, but it seems like a minimal patch that eddyb has cherry picked cleanly. If we don't make a decision by the time we're going to begin cutting stable this'll probably not go in.

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Feb 11, 2018
Closed
@alexcrichton
Copy link
Member

@bors: r+ p=100

@bors
Copy link
Contributor

bors commented Feb 11, 2018

📌 Commit 3ed7697 has been approved by alexcrichton

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 11, 2018
@bors
Copy link
Contributor

bors commented Feb 11, 2018

⌛ Testing commit 3ed7697 with merge 29b633c09f17d329878af0b0c569a2ff7d0e469c...

@bors
Copy link
Contributor

bors commented Feb 11, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 11, 2018
@pietroalbini
Copy link
Member

no space left on device -- #48144

kennytm and others added 2 commits February 11, 2018 16:30
@kennytm @Mark-Simulacrum
compiletest: Delete the executable immediately after running.
8088e20 
This should save a lot of space on musl test cases (whose standard library
are linked statically).
@Mark-Simulacrum
Delete executables if the test ran successfully.
17d0d6a 
This isn't a perfect heuristic, but since the amount of run-fail tests
is far lower than run-pass tests for now, it should be sufficient to
ensure that we don't run into CI limits. This makes it possible to run
the test binary manually (e.g., under gdb/lldb) if it failed to attempt
to find out why.
@Mark-Simulacrum
Copy link
Member Author

Added #48144.

@bors r=alexcrichton p=100 retry force

@Mark-Simulacrum
Copy link
Member Author

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Feb 11, 2018

📌 Commit 17d0d6a has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2018
@bors
Copy link
Contributor

bors commented Feb 12, 2018

⌛ Testing commit 17d0d6a with merge bc4f7624eada6eb7adcdbda87fce95fb1be123e9...

@bors
Copy link
Contributor

bors commented Feb 12, 2018

💔 Test failed - status-travis

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 12, 2018
@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 12, 2018
@Mark-Simulacrum
Copy link
Member Author

@bors retry

Looks spurious.

[00:04:55] fatal: unable to access 'https://github.com/rust-lang/rust.git/': Empty reply from server
[00:04:55] thread 'main' panicked at 'command did not execute successfully: "git" "ls-remote" "origin" "master"
[00:04:55] expected success, got: exit code: 128', /checkout/src/build_helper/lib.rs:116:8

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2018
@bors
Copy link
Contributor

bors commented Feb 12, 2018

⌛ Testing commit 17d0d6a with merge 97374005c34adb40f0e94d3ae014c50423afe08d...

@bors
Copy link
Contributor

bors commented Feb 12, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 12, 2018
@Mark-Simulacrum
Copy link
Member Author

@bors retry -- appveyor timed out

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2018
@bors
Copy link
Contributor

bors commented Feb 12, 2018

⌛ Testing commit 17d0d6a with merge ed2c0f0...

bors added a commit that referenced this pull request Feb 12, 2018
@bors
Auto merge of #48146 - Mark-Simulacrum:beta-next, r=alexcrichton
ed2c0f0 
[beta] Release notes, dist with time crate, and #48092

Backports of
 - #48092
 - #48013
 - #47286
 - #48144
@bors
Copy link
Contributor

bors commented Feb 12, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing ed2c0f0 to beta...

@bors bors merged commit 17d0d6a into rust-lang:beta Feb 12, 2018
@Mark-Simulacrum Mark-Simulacrum deleted the beta-next branch February 12, 2018 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Mark-Simulacrum @rust-highfive @alexcrichton @bors @pietroalbini @onur @eddyb @kennytm