Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type_dependent_defs ICE on method calls #49244

Merged
merged 2 commits into from
Mar 22, 2018
Merged

Fix type_dependent_defs ICE on method calls #49244

merged 2 commits into from
Mar 22, 2018

Conversation

varkor
Copy link
Member

@varkor varkor commented Mar 21, 2018

Fixes #49241.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 21, 2018
estebank
estebank reviewed Mar 21, 2018
View reviewed changes
src/test/compile-fail/type-dependent-def-issue-49241.rs Outdated
@@ -0,0 +1,15 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this test to ui?

@estebank
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 21, 2018

📌 Commit 3272b63 has been approved by estebank

@bors
Copy link
Contributor

bors commented Mar 21, 2018

🌲 The tree is currently closed for pull requests below priority 30, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2018
@kennytm kennytm mentioned this pull request Mar 22, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Mar 22, 2018
@kennytm
Rollup merge of rust-lang#49244 - varkor:type_dependent_defs_ExprMeth…
d54f74e 
…odCall, r=estebank

Fix type_dependent_defs ICE on method calls

Fixes rust-lang#49241.
bors added a commit that referenced this pull request Mar 22, 2018
@bors
Auto merge of #49264 - kennytm:rollup, r=kennytm
5092c6b 
Rollup of 23 pull requests

- Successful merges: #48374, #48596, #48759, #48939, #49029, #49069, #49093, #49109, #49117, #49140, #49158, #49188, #49189, #49209, #49211, #49216, #49225, #49231, #49234, #49242, #49244, #49105, #49038
- Failed merges:
@alexcrichton alexcrichton merged commit 3272b63 into rust-lang:master Mar 22, 2018
@varkor varkor deleted the type_dependent_defs_ExprMethodCall branch March 22, 2018 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebank estebank estebank left review comments

Assignees

@eddyb eddyb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@varkor @rust-highfive @estebank @bors @alexcrichton @eddyb