Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give SliceIndex impls a test suite of girth befitting the implementation #50010

Merged
merged 8 commits into from
May 11, 2018
Merged

Give SliceIndex impls a test suite of girth befitting the implementation #50010

merged 8 commits into from
May 11, 2018

Commits on Apr 30, 2018

  1. str/slice: factor out overflow error messages

    @ExpHP
    ExpHP committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    5ab4c81 View commit details
    Browse the repository at this point in the history

  2. Clean up the other Slice*Inclusive impls for str 

    A previous PR fixed one method that was legitimately buggy;
this cleans up the rest to be less diverse, mirroring the
corresponding impls on [T] to the greatest extent possible
without introducing any unnecessary UTF-8 boundary checks at 0.
    @ExpHP
    ExpHP committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    6b749b0 View commit details
    Browse the repository at this point in the history

  3. update libcore's comment about str tests

    @ExpHP
    ExpHP committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    4fab167 View commit details
    Browse the repository at this point in the history

  4. collect str SliceIndex tests into a mod 

    GitHub users: I think you can add ?w=1 to the url
for a vastly cleaner whitespace-ignoring diff
    @ExpHP
    ExpHP committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    0842dc6 View commit details
    Browse the repository at this point in the history

  5. flesh out tests for SliceIndex 

    m*n lines of implementation deserves m*n lines of tests
    @ExpHP
    ExpHP committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    ce66f5d View commit details
    Browse the repository at this point in the history

  6. decrease false negatives for str overflow test

    @ExpHP
    ExpHP committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    02b3da1 View commit details
    Browse the repository at this point in the history

  7. revise macro in slice tests

    @ExpHP
    ExpHP committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    030aa9b View commit details
    Browse the repository at this point in the history

  8. revise test gen macro for str

    @ExpHP
    ExpHP committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    f1d7b45 View commit details
    Browse the repository at this point in the history