Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar documentation wrt Unicode identifiers #50790

Merged
merged 1 commit into from
May 18, 2018

Commits on May 16, 2018

  1. Fix grammar documentation wrt Unicode identifiers

    The grammar defines identifiers in terms of XID_start and XID_continue,
    but this is referring to the unstable non_ascii_idents feature.
    The documentation implies that non_ascii_idents is forthcoming, but this
    is left over from pre-1.0 documentation; in reality, non_ascii_idents
    has been without even an RFC for several years now, and will not be
    stabilized anytime soon. Furthermore, according to the tracking issue at
    rust-lang#28979 , it's highly
    questionable whether or not this feature will use XID_start or
    XID_continue even when or if non_ascii_idents is stabilized.
    This commit fixes this by respecifying identifiers as the usual
    [a-zA-Z_][a-zA-Z0-9_]*
    bstrie committed May 16, 2018
    Configuration menu
    Copy the full SHA
    ce0b7cc View commit details
    Browse the repository at this point in the history