diff --git a/src/librustc_resolve/build_reduced_graph.rs b/src/librustc_resolve/build_reduced_graph.rs index 80f6c263e1999..37868a83e3421 100644 --- a/src/librustc_resolve/build_reduced_graph.rs +++ b/src/librustc_resolve/build_reduced_graph.rs @@ -181,6 +181,23 @@ impl<'a, 'cl> Resolver<'a, 'cl> { self.session.features_untracked().uniform_paths); let source = module_path[0]; + + // HACK(eddyb) For `use x::{self, ...};`, use the ID of the + // `self` nested import for the canary. This allows the + // ambiguity reporting scope to ignore false positives + // in the same way it does for `use x;` (by comparing IDs). + let mut canary_id = id; + if let ast::UseTreeKind::Nested(ref items) = use_tree.kind { + for &(ref use_tree, id) in items { + if let ast::UseTreeKind::Simple(..) = use_tree.kind { + if use_tree.ident().name == keywords::SelfValue.name() { + canary_id = id; + break; + } + } + } + } + // Helper closure to emit a canary with the given base path. let emit = |this: &mut Self, base: Option| { let subclass = SingleImport { @@ -200,7 +217,7 @@ impl<'a, 'cl> Resolver<'a, 'cl> { base.into_iter().collect(), subclass.clone(), source.span, - id, + canary_id, root_use_tree.span, root_id, ty::Visibility::Invisible, diff --git a/src/librustc_resolve/resolve_imports.rs b/src/librustc_resolve/resolve_imports.rs index c60f9293d58e7..73c9af0d11c47 100644 --- a/src/librustc_resolve/resolve_imports.rs +++ b/src/librustc_resolve/resolve_imports.rs @@ -664,6 +664,14 @@ impl<'a, 'b:'a, 'c: 'b> ImportResolver<'a, 'b, 'c> { self.per_ns(|_, ns| { if let Some(result) = result[ns].get().ok() { + if let NameBindingKind::Import { directive, .. } = result.kind { + // Skip canaries that resolve to the import itself. + // These come from `use crate_name;`, which isn't really + // ambiguous, as the import can't actually shadow itself. + if directive.id == import.id { + return; + } + } if has_explicit_self { // There should only be one `self::x` (module-scoped) canary. assert_eq!(canary_results[ns].module_scope, None); @@ -718,22 +726,6 @@ impl<'a, 'b:'a, 'c: 'b> ImportResolver<'a, 'b, 'c> { errors = true; - // Special-case the error when `self::x` finds its own `use x;`. - if has_external_crate && - results.module_scope == Some(span) && - results.block_scopes.is_empty() { - let msg = format!("`{}` import is redundant", name); - this.session.struct_span_err(span, &msg) - .span_label(span, - format!("refers to external crate `::{}`", name)) - .span_label(span, - format!("defines `self::{}`, shadowing itself", name)) - .help(&format!("remove or write `::{}` explicitly instead", name)) - .note("relative `use` paths enabled by `#![feature(uniform_paths)]`") - .emit(); - return; - } - let msg = format!("`{}` import is ambiguous", name); let mut err = this.session.struct_span_err(span, &msg); let mut suggestion_choices = String::new(); diff --git a/src/test/ui/rust-2018/uniform-paths/redundant.rs b/src/test/run-pass/redundant.rs similarity index 74% rename from src/test/ui/rust-2018/uniform-paths/redundant.rs rename to src/test/run-pass/redundant.rs index 8f384b7e7af6a..39bd3160695e3 100644 --- a/src/test/ui/rust-2018/uniform-paths/redundant.rs +++ b/src/test/run-pass/redundant.rs @@ -14,4 +14,16 @@ use std; -fn main() {} +mod foo { + pub use std as my_std; +} + +mod bar { + pub use std::{self}; +} + +fn main() { + self::std::io::stdout(); + foo::my_std::io::stdout(); + bar::std::io::stdout(); +} diff --git a/src/test/ui/rust-2018/uniform-paths/redundant.stderr b/src/test/ui/rust-2018/uniform-paths/redundant.stderr deleted file mode 100644 index dd38407e1646b..0000000000000 --- a/src/test/ui/rust-2018/uniform-paths/redundant.stderr +++ /dev/null @@ -1,14 +0,0 @@ -error: `std` import is redundant - --> $DIR/redundant.rs:15:5 - | -LL | use std; - | ^^^ - | | - | refers to external crate `::std` - | defines `self::std`, shadowing itself - | - = help: remove or write `::std` explicitly instead - = note: relative `use` paths enabled by `#![feature(uniform_paths)]` - -error: aborting due to previous error -