Add slice::rchunks(), rchunks_mut(), rchunks_exact() and rchunks_exact_mut() #54580
Conversation
|
r? @dtolnay (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
kennytm
added
the
T-libs-api
|
Simon would you be able to take this review? I haven't gotten a chance to look at the code but this sounds like a natural extension of #47115. r? @SimonSapin |
|
☔ The latest upstream changes (presumably #54554) made this pull request unmergeable. Please resolve the merge conflicts. |
Rebased |
|
☔ The latest upstream changes (presumably #54924) made this pull request unmergeable. Please resolve the merge conflicts. |
Rebased again |
|
Looks great, thanks! Sorry for the repeated conflicts and rebasing. r=me with the tracking issue changed to #55177 |
|
Updated the tracking issue in the commit, thanks for the review and also thanks for creating the tracking issue :) |
…t_mut() These work exactly like the normal chunks iterators but start creating chunks from the end of the slice. See rust-lang#55177 for the tracking issue
|
travis is green again |
|
@bors r+ |
|
📌 Commit 80a8e5c has been approved by |
bors
added
S-waiting-on-bors
Add slice::rchunks(), rchunks_mut(), rchunks_exact() and rchunks_exact_mut() These work exactly like the normal chunks iterators but start creating chunks from the end of the slice. ---- The new iterators were motivated by a [comment](#47115 (comment)) by @DutchGhost. ~~~This currently includes the commits from #54537 to not have to rename things twice or have merge conflicts. I'll force-push a new version of the branch ones those are in master.~~~ Also the stabilization tracking issue is just some number right now. I'll create the corresponding issue once this is reviewed and otherwise mergeable. cc @DutchGhost
|
☀️ Test successful - status-appveyor, status-travis |
These work exactly like the normal chunks iterators but start creating
chunks from the end of the slice.
The new iterators were motivated by a comment by @DutchGhost.