Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] Link to alloc_system by default #55202

Closed
wants to merge 1 commit into from
Closed

[wip] Link to alloc_system by default #55202

wants to merge 1 commit into from

Conversation

alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Oct 19, 2018 •
edited
Loading

I'm curious to see the perf impact we have from moving away from jemalloc, so using this as a placeholder to run a perf run!

@alexcrichton alexcrichton changed the title Link to alloc_system by default [wip] Link to alloc_system by default Oct 19, 2018
@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 19, 2018
@alexcrichton
Copy link
Member Author

r? @alexcrichton

@bors: try

@bors
Copy link
Contributor

bors commented Oct 19, 2018

⌛ Trying commit 635cb31 with merge 7e7928d...

bors added a commit that referenced this pull request Oct 19, 2018
@bors
Auto merge of #55202 - alexcrichton:alloc-system, r=<try>
7e7928d 
[wip] Link to alloc_system by default

I'm curious to see the perf impact we have from moving away from jemalloc, so using this as a placeholder to run a perf run!
@bors
Copy link
Contributor

bors commented Oct 19, 2018

☀️ Test successful - status-travis
State: approved= try=True

@alexcrichton

This comment has been minimized.

Sign in to view
@alexcrichton
Copy link
Member Author

@rust-timer build 7e7928d

@rust-timer
Copy link
Collaborator

Success: Queued 7e7928d with parent 74ff7dc, comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit 7e7928d

@alexcrichton
Copy link
Member Author

Mischief managed! (data collected)

@alexcrichton alexcrichton deleted the alloc-system branch October 20, 2018 02:43
@brson brson mentioned this pull request Oct 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexcrichton @rust-highfive @bors @rust-timer @oli-obk