[stable] Add a few critical fixes to the 1.31.0 release #56518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two `TyCtxt`s, one global, one local. Methods must be called on the right one, as they differ by invariant lifetimes.
|
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ p=1000 |
|
📌 Commit f41b48a has been approved by |
bors
added
S-waiting-on-bors
This was referenced Dec 4, 2018
|
⌛ Testing commit f41b48a with merge 55a0c797db19e2add2c84e58d879c06553a74238... |
and update it so that links are correct
|
@bors r- |
bors
added
S-waiting-on-author
|
@bors retry |
bors
added
S-waiting-on-bors
|
📌 Commit 6d54f6d has been approved by |
bors
added a commit
that referenced
this pull request
Dec 4, 2018
[stable] Add a few critical fixes to the 1.31.0 release This PR cherry-picks the following PRs to stable: * #56467: Bump stack size to 32MB * #56486: Propagate all closure requirements to the caller * #56519: update edition guide The changes will be included in the final 1.31.0 binary (to avoid a point release). To deploy the build to dev-static the old manifest needs to be removed from the bucket after the PR is merged. cc @rust-lang/core @rust-lang/release @rust-lang/compiler r? @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
|
this might fix #55390, I'll test with this nightly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks the following PRs to stable:
The changes will be included in the final 1.31.0 binary (to avoid a point release). To deploy the build to dev-static the old manifest needs to be removed from the bucket after the PR is merged.
cc @rust-lang/core @rust-lang/release @rust-lang/compiler
r? @alexcrichton