Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add match arm scopes and other scope fixes #60174

Merged
merged 11 commits into from
May 23, 2019
Merged

Add match arm scopes and other scope fixes #60174

merged 11 commits into from
May 23, 2019

Commits on May 21, 2019

  1. Remove unused parameter from in(_opt)?_scope

    @matthewjasper
    matthewjasper committed May 21, 2019
    Configuration menu
    Copy the full SHA
    615c23f View commit details
    Browse the repository at this point in the history

  2. Give match arms an HirId and a Span

    @matthewjasper
    matthewjasper committed May 21, 2019
    Configuration menu
    Copy the full SHA
    4bfb045 View commit details
    Browse the repository at this point in the history

  3. Respect lint attributes on match arms

    @matthewjasper
    matthewjasper committed May 21, 2019
    Configuration menu
    Copy the full SHA
    e784595 View commit details
    Browse the repository at this point in the history

  4. Handle the visibility/lint scope distinction better 

    * Don't generate an extra lint scope for each `let` statement.
* Place match guards inside the visiblility scope of the bindings for
  their arm.
    @matthewjasper
    matthewjasper committed May 21, 2019
    Configuration menu
    Copy the full SHA
    af6a9a2 View commit details
    Browse the repository at this point in the history

  5. Give match arms a drop/region scope 

    Also give arms the correct lint scope in MIR.
    @matthewjasper
    matthewjasper committed May 21, 2019
    Configuration menu
    Copy the full SHA
    f506aea View commit details
    Browse the repository at this point in the history

  6. Remove MIR borrowck hack for old match scopes

    @matthewjasper
    matthewjasper committed May 21, 2019
    Configuration menu
    Copy the full SHA
    0f50724 View commit details
    Browse the repository at this point in the history

  7. Emit fake borrows for all tests 

    I was incorrectly under the impression that this would only lead to
duplicates. See `mir-opt/match-arm-scope.rs` (upcomming commit) for a
case where we didn't emit a fake borrow of `items.1`.
    @matthewjasper
    matthewjasper committed May 21, 2019
    Configuration menu
    Copy the full SHA
    b5643f1 View commit details
    Browse the repository at this point in the history

  8. Schedule storage-dead of temporaries sooner 

    This ensures that we will correctly generate a storage-dead if the
initializing expression diverges.
    @matthewjasper
    matthewjasper committed May 21, 2019
    Configuration menu
    Copy the full SHA
    abab9ef View commit details
    Browse the repository at this point in the history

  9. Add a test for match scopes

    @matthewjasper
    matthewjasper committed May 21, 2019
    Configuration menu
    Copy the full SHA
    2420d82 View commit details
    Browse the repository at this point in the history

  10. Comment style fixes 

    Co-Authored-By: matthewjasper <mjjasper1@gmail.com>
    @Centril @matthewjasper
    Centril and matthewjasper committed May 21, 2019
    Configuration menu
    Copy the full SHA
    015a451 View commit details
    Browse the repository at this point in the history

  11. Fix match ergonomics suggestion

    @matthewjasper
    matthewjasper committed May 21, 2019
    Configuration menu
    Copy the full SHA
    0835048 View commit details
    Browse the repository at this point in the history