Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Permit unwinding through FFI by default #61569

Merged
merged 3 commits into from
Jun 8, 2019

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jun 6, 2019

This repeats #60716 for Rust 1.36, as #58794 is not yet resolved.

cc @rust-lang/release
r? @Mark-Simulacrum

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 6, 2019
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 6, 2019

📌 Commit 32cd647 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2019
@bors
Copy link
Contributor

bors commented Jun 6, 2019

⌛ Testing commit 32cd647 with merge c245042ba5aef859707160b63d2027f6fd5762f9...

@bors
Copy link
Contributor

bors commented Jun 6, 2019

💔 Test failed - checks-travis

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:04:44]    Compiling aho-corasick v0.7.3
[00:04:45]    Compiling bstr v0.1.4
[00:04:45]    Compiling clap v2.33.0
[00:04:45]    Compiling tar v0.4.26
[00:04:49] error[E0277]: the trait bound `rand_hc::Hc128Rng: rand_core::SeedableRng` is not satisfied
[00:04:49]   --> /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/rand-0.6.5/src/rngs/std.rs:55:6
[00:04:49]    |
[00:04:49] 55 | impl SeedableRng for StdRng {
[00:04:49]    |      ^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Rng`
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_isaac::IsaacRng: rand_core::SeedableRng` is not satisfied
[00:04:49]    |
[00:04:49]    |
[00:04:49] 50 | impl SeedableRng for IsaacRng {
[00:04:49]    |      ^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_isaac::IsaacRng`
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_isaac::Isaac64Rng: rand_core::SeedableRng` is not satisfied
[00:04:49]    |
[00:04:49]    |
[00:04:49] 96 | impl SeedableRng for Isaac64Rng {
[00:04:49]    |      ^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_isaac::Isaac64Rng`
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_hc::Hc128Rng: rand_core::SeedableRng` is not satisfied
[00:04:49]     |
[00:04:49]     |
[00:04:49] 198 | impl SeedableRng for Hc128Rng {
[00:04:49]     |      ^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Rng`
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_xorshift::XorShiftRng: rand_core::SeedableRng` is not satisfied
[00:04:49]     |
[00:04:49]     |
[00:04:49] 239 | impl SeedableRng for XorShiftRng {
[00:04:49]     |      ^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_xorshift::XorShiftRng`
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_hc::Hc128Rng: rand_core::SeedableRng` is not satisfied
[00:04:49]     |
[00:04:49]     |
[00:04:49] 279 | impl SeedableRng for StdRng {
[00:04:49]     |      ^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Rng`
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_hc::Hc128Core: rand_core::block::BlockRngCore` is not satisfied
[00:04:49]   --> /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/rand-0.6.5/src/rngs/thread.rs:73:5
[00:04:49]    |
[00:04:49] 73 |     rng: *mut ReseedingRng<Hc128Core, EntropyRng>,
[00:04:49]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `rand_core::block::BlockRngCore` is not implemented for `rand_hc::Hc128Core`
[00:04:49]    |
[00:04:49] note: required by `rngs::adapter::reseeding::ReseedingRng`
[00:04:49]   --> /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/rand-0.6.5/src/rngs/adapter/reseeding.rs:88:1
[00:04:49]    |
[00:04:49] 88 | / pub struct ReseedingRng<R, Rsdr>(BlockRng<ReseedingCore<R, Rsdr>>)
[00:04:49] 89 | | where R: BlockRngCore + SeedableRng,
[00:04:49] 90 | |       Rsdr: RngCore;
[00:04:49] 
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_hc::Hc128Core: rand_core::SeedableRng` is not satisfied
[00:04:49]   --> /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/rand-0.6.5/src/rngs/thread.rs:73:5
[00:04:49]    |
[00:04:49] 73 |     rng: *mut ReseedingRng<Hc128Core, EntropyRng>,
[00:04:49]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Core`
[00:04:49]    |
[00:04:49] note: required by `rngs::adapter::reseeding::ReseedingRng`
[00:04:49]   --> /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/rand-0.6.5/src/rngs/adapter/reseeding.rs:88:1
[00:04:49]    |
[00:04:49] 88 | / pub struct ReseedingRng<R, Rsdr>(BlockRng<ReseedingCore<R, Rsdr>>)
[00:04:49] 89 | | where R: BlockRngCore + SeedableRng,
[00:04:49] 90 | |       Rsdr: RngCore;
[00:04:49] 
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_hc::Hc128Core: rand_core::block::BlockRngCore` is not satisfied
[00:04:49]   --> /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/rand-0.6.5/src/rngs/thread.rs:76:1
[00:04:49] 76 | / thread_local!(
[00:04:49] 76 | / thread_local!(
[00:04:49] 77 | |     static THREAD_RNG_KEY: UnsafeCell<ReseedingRng<Hc128Core, EntropyRng>> = {
[00:04:49] 78 | |         let mut entropy_source = EntropyRng::new();
[00:04:49] 79 | |         let r = Hc128Core::from_rng(&mut entropy_source).unwrap_or_else(|err|
[00:04:49] 85 | |     }
[00:04:49] 86 | | );
[00:04:49] 86 | | );
[00:04:49]    | |__^ the trait `rand_core::block::BlockRngCore` is not implemented for `rand_hc::Hc128Core`
[00:04:49]    |
[00:04:49] note: required by `rngs::adapter::reseeding::ReseedingRng`
[00:04:49]   --> /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/rand-0.6.5/src/rngs/adapter/reseeding.rs:88:1
[00:04:49]    |
[00:04:49] 88 | / pub struct ReseedingRng<R, Rsdr>(BlockRng<ReseedingCore<R, Rsdr>>)
[00:04:49] 89 | | where R: BlockRngCore + SeedableRng,
[00:04:49] 90 | |       Rsdr: RngCore;
[00:04:49]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:04:49] 
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_hc::Hc128Core: rand_core::SeedableRng` is not satisfied
[00:04:49]   --> /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/rand-0.6.5/src/rngs/thread.rs:76:1
[00:04:49] 76 | / thread_local!(
[00:04:49] 76 | / thread_local!(
[00:04:49] 77 | |     static THREAD_RNG_KEY: UnsafeCell<ReseedingRng<Hc128Core, EntropyRng>> = {
[00:04:49] 78 | |         let mut entropy_source = EntropyRng::new();
[00:04:49] 79 | |         let r = Hc128Core::from_rng(&mut entropy_source).unwrap_or_else(|err|
[00:04:49] 85 | |     }
[00:04:49] 86 | | );
[00:04:49] 86 | | );
[00:04:49]    | |__^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Core`
[00:04:49]    |
[00:04:49] note: required by `rngs::adapter::reseeding::ReseedingRng`
[00:04:49]   --> /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/rand-0.6.5/src/rngs/adapter/reseeding.rs:88:1
[00:04:49]    |
[00:04:49] 88 | / pub struct ReseedingRng<R, Rsdr>(BlockRng<ReseedingCore<R, Rsdr>>)
[00:04:49] 89 | | where R: BlockRngCore + SeedableRng,
[00:04:49] 90 | |       Rsdr: RngCore;
[00:04:49]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:04:49] 
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_hc::Hc128Core: rand_core::block::BlockRngCore` is not satisfied
[00:04:49]   --> /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/rand-0.6.5/src/rngs/thread.rs:76:1
[00:04:49] 76 | / thread_local!(
[00:04:49] 76 | / thread_local!(
[00:04:49] 77 | |     static THREAD_RNG_KEY: UnsafeCell<ReseedingRng<Hc128Core, EntropyRng>> = {
[00:04:49] 78 | |         let mut entropy_source = EntropyRng::new();
[00:04:49] 79 | |         let r = Hc128Core::from_rng(&mut entropy_source).unwrap_or_else(|err|
[00:04:49] 85 | |     }
[00:04:49] 86 | | );
[00:04:49] 86 | | );
[00:04:49]    | |__^ the trait `rand_core::block::BlockRngCore` is not implemented for `rand_hc::Hc128Core`
[00:04:49]    |
[00:04:49] note: required by `rngs::adapter::reseeding::ReseedingRng`
[00:04:49]   --> /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/rand-0.6.5/src/rngs/adapter/reseeding.rs:88:1
[00:04:49]    |
[00:04:49] 88 | / pub struct ReseedingRng<R, Rsdr>(BlockRng<ReseedingCore<R, Rsdr>>)
[00:04:49] 89 | | where R: BlockRngCore + SeedableRng,
[00:04:49] 90 | |       Rsdr: RngCore;
[00:04:49]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:04:49] 
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_hc::Hc128Core: rand_core::SeedableRng` is not satisfied
[00:04:49]   --> /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/rand-0.6.5/src/rngs/thread.rs:76:1
[00:04:49] 76 | / thread_local!(
[00:04:49] 76 | / thread_local!(
[00:04:49] 77 | |     static THREAD_RNG_KEY: UnsafeCell<ReseedingRng<Hc128Core, EntropyRng>> = {
[00:04:49] 78 | |         let mut entropy_source = EntropyRng::new();
[00:04:49] 79 | |         let r = Hc128Core::from_rng(&mut entropy_source).unwrap_or_else(|err|
[00:04:49] 85 | |     }
[00:04:49] 86 | | );
[00:04:49] 86 | | );
[00:04:49]    | |__^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Core`
[00:04:49]    |
[00:04:49] note: required by `rngs::adapter::reseeding::ReseedingRng`
[00:04:49]   --> /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/rand-0.6.5/src/rngs/adapter/reseeding.rs:88:1
[00:04:49]    |
[00:04:49] 88 | / pub struct ReseedingRng<R, Rsdr>(BlockRng<ReseedingCore<R, Rsdr>>)
[00:04:49] 89 | | where R: BlockRngCore + SeedableRng,
[00:04:49] 90 | |       Rsdr: RngCore;
[00:04:49]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:04:49] 
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_hc::Hc128Core: rand_core::block::BlockRngCore` is not satisfied
[00:04:49]   --> /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/rand-0.6.5/src/rngs/thread.rs:76:1
[00:04:49] 76 | / thread_local!(
[00:04:49] 76 | / thread_local!(
[00:04:49] 77 | |     static THREAD_RNG_KEY: UnsafeCell<ReseedingRng<Hc128Core, EntropyRng>> = {
[00:04:49] 78 | |         let mut entropy_source = EntropyRng::new();
[00:04:49] 79 | |         let r = Hc128Core::from_rng(&mut entropy_source).unwrap_or_else(|err|
[00:04:49] 85 | |     }
[00:04:49] 86 | | );
[00:04:49] 86 | | );
[00:04:49]    | |__^ the trait `rand_core::block::BlockRngCore` is not implemented for `rand_hc::Hc128Core`
[00:04:49]    |
[00:04:49] note: required by `rngs::adapter::reseeding::ReseedingRng`
[00:04:49]   --> /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/rand-0.6.5/src/rngs/adapter/reseeding.rs:88:1
[00:04:49]    |
[00:04:49] 88 | / pub struct ReseedingRng<R, Rsdr>(BlockRng<ReseedingCore<R, Rsdr>>)
[00:04:49] 89 | | where R: BlockRngCore + SeedableRng,
[00:04:49] 90 | |       Rsdr: RngCore;
[00:04:49]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:04:49] 
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_hc::Hc128Core: rand_core::SeedableRng` is not satisfied
[00:04:49]   --> /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/rand-0.6.5/src/rngs/thread.rs:76:1
[00:04:49] 76 | / thread_local!(
[00:04:49] 76 | / thread_local!(
[00:04:49] 77 | |     static THREAD_RNG_KEY: UnsafeCell<ReseedingRng<Hc128Core, EntropyRng>> = {
[00:04:49] 78 | |         let mut entropy_source = EntropyRng::new();
[00:04:49] 79 | |         let r = Hc128Core::from_rng(&mut entropy_source).unwrap_or_else(|err|
[00:04:49] 85 | |     }
[00:04:49] 86 | | );
[00:04:49] 86 | | );
[00:04:49]    | |__^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Core`
[00:04:49]    |
[00:04:49] note: required by `rngs::adapter::reseeding::ReseedingRng`
[00:04:49]   --> /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/rand-0.6.5/src/rngs/adapter/reseeding.rs:88:1
[00:04:49]    |
[00:04:49] 88 | / pub struct ReseedingRng<R, Rsdr>(BlockRng<ReseedingCore<R, Rsdr>>)
[00:04:49] 89 | | where R: BlockRngCore + SeedableRng,
[00:04:49] 90 | |       Rsdr: RngCore;
[00:04:49]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:04:49] 
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_hc::Hc128Core: rand_core::block::BlockRngCore` is not satisfied
[00:04:49]   --> /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/rand-0.6.5/src/rngs/thread.rs:76:1
[00:04:49] 76 | / thread_local!(
[00:04:49] 76 | / thread_local!(
[00:04:49] 77 | |     static THREAD_RNG_KEY: UnsafeCell<ReseedingRng<Hc128Core, EntropyRng>> = {
[00:04:49] 78 | |         let mut entropy_source = EntropyRng::new();
[00:04:49] 79 | |         let r = Hc128Core::from_rng(&mut entropy_source).unwrap_or_else(|err|
[00:04:49] 85 | |     }
[00:04:49] 86 | | );
[00:04:49] 86 | | );
[00:04:49]    | |__^ the trait `rand_core::block::BlockRngCore` is not implemented for `rand_hc::Hc128Core`
[00:04:49]    |
[00:04:49] note: required by `rngs::adapter::reseeding::ReseedingRng`
[00:04:49]   --> /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/rand-0.6.5/src/rngs/adapter/reseeding.rs:88:1
[00:04:49]    |
[00:04:49] 88 | / pub struct ReseedingRng<R, Rsdr>(BlockRng<ReseedingCore<R, Rsdr>>)
[00:04:49] 89 | | where R: BlockRngCore + SeedableRng,
[00:04:49] 90 | |       Rsdr: RngCore;
[00:04:49]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:04:49] 
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_hc::Hc128Core: rand_core::SeedableRng` is not satisfied
[00:04:49]   --> /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/rand-0.6.5/src/rngs/thread.rs:76:1
[00:04:49] 76 | / thread_local!(
[00:04:49] 76 | / thread_local!(
[00:04:49] 77 | |     static THREAD_RNG_KEY: UnsafeCell<ReseedingRng<Hc128Core, EntropyRng>> = {
[00:04:49] 78 | |         let mut entropy_source = EntropyRng::new();
[00:04:49] 79 | |         let r = Hc128Core::from_rng(&mut entropy_source).unwrap_or_else(|err|
[00:04:49] 85 | |     }
[00:04:49] 86 | | );
[00:04:49] 86 | | );
[00:04:49]    | |__^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Core`
[00:04:49]    |
[00:04:49] note: required by `rngs::adapter::reseeding::ReseedingRng`
[00:04:49]   --> /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/rand-0.6.5/src/rngs/adapter/reseeding.rs:88:1
[00:04:49]    |
[00:04:49] 88 | / pub struct ReseedingRng<R, Rsdr>(BlockRng<ReseedingCore<R, Rsdr>>)
[00:04:49] 89 | | where R: BlockRngCore + SeedableRng,
[00:04:49] 90 | |       Rsdr: RngCore;
[00:04:49]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:04:49] 
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_hc::Hc128Rng: rand_core::SeedableRng` is not satisfied
[00:04:49]   --> /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/rand-0.6.5/src/rngs/std.rs:56:5
[00:04:49]    |
[00:04:49] 56 |     type Seed = <Hc128Rng as SeedableRng>::Seed;
[00:04:49]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Rng`
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_hc::Hc128Rng: rand_core::SeedableRng` is not satisfied
[00:04:49]   --> /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/rand-0.6.5/src/rngs/std.rs:58:5
[00:04:49]    |
[00:04:49] 58 | /     fn from_seed(seed: Self::Seed) -> Self {
[00:04:49] 59 | |         StdRng(Hc128Rng::from_seed(seed))
[00:04:49] 60 | |     }
[00:04:49]    | |_____^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Rng`
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_isaac::IsaacRng: rand_core::SeedableRng` is not satisfied
[00:04:49]    |
[00:04:49]    |
[00:04:49] 51 |     type Seed = <rand_isaac::IsaacRng as SeedableRng>::Seed;
[00:04:49]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_isaac::IsaacRng`
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_isaac::IsaacRng: rand_core::SeedableRng` is not satisfied
[00:04:49]    |
[00:04:49]    |
[00:04:49] 53 | /     fn from_seed(seed: Self::Seed) -> Self {
[00:04:49] 54 | |         IsaacRng(rand_isaac::IsaacRng::from_seed(seed))
[00:04:49] 55 | |     }
[00:04:49]    | |_____^ the trait `rand_core::SeedableRng` is not implemented for `rand_isaac::IsaacRng`
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_isaac::Isaac64Rng: rand_core::SeedableRng` is not satisfied
[00:04:49]    |
[00:04:49]    |
[00:04:49] 97 |     type Seed = <rand_isaac::Isaac64Rng as SeedableRng>::Seed;
[00:04:49]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_isaac::Isaac64Rng`
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_isaac::Isaac64Rng: rand_core::SeedableRng` is not satisfied
[00:04:49]     |
[00:04:49]     |
[00:04:49] 99  | /     fn from_seed(seed: Self::Seed) -> Self {
[00:04:49] 100 | |         Isaac64Rng(rand_isaac::Isaac64Rng::from_seed(seed))
[00:04:49] 101 | |     }
[00:04:49]     | |_____^ the trait `rand_core::SeedableRng` is not implemented for `rand_isaac::Isaac64Rng`
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_hc::Hc128Rng: rand_core::SeedableRng` is not satisfied
[00:04:49]     |
[00:04:49]     |
[00:04:49] 199 |     type Seed = <rand_hc::Hc128Rng as SeedableRng>::Seed;
[00:04:49]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Rng`
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_hc::Hc128Rng: rand_core::SeedableRng` is not satisfied
[00:04:49]     |
[00:04:49]     |
[00:04:49] 201 | /     fn from_seed(seed: Self::Seed) -> Self {
[00:04:49] 202 | |         Hc128Rng(rand_hc::Hc128Rng::from_seed(seed))
[00:04:49] 203 | |     }
[00:04:49]     | |_____^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Rng`
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_xorshift::XorShiftRng: rand_core::SeedableRng` is not satisfied
[00:04:49]     |
[00:04:49]     |
[00:04:49] 240 |     type Seed = <::rand_xorshift::XorShiftRng as SeedableRng>::Seed;
[00:04:49]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_xorshift::XorShiftRng`
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_xorshift::XorShiftRng: rand_core::SeedableRng` is not satisfied
[00:04:49]     |
[00:04:49]     |
[00:04:49] 242 | /     fn from_seed(seed: Self::Seed) -> Self {
[00:04:49] 243 | |         XorShiftRng(::rand_xorshift::XorShiftRng::from_seed(seed))
[00:04:49] 244 | |     }
[00:04:49]     | |_____^ the trait `rand_core::SeedableRng` is not implemented for `rand_xorshift::XorShiftRng`
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_hc::Hc128Rng: rand_core::SeedableRng` is not satisfied
[00:04:49]     |
[00:04:49]     |
[00:04:49] 280 |     type Seed = <rngs::StdRng as SeedableRng>::Seed;
[00:04:49]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Rng`
[00:04:49] 
[00:04:49] error[E0277]: the trait bound `rand_hc::Hc128Rng: rand_core::SeedableRng` is not satisfied
[00:04:49]     |
[00:04:49]     |
[00:04:49] 282 | /     fn from_seed(seed: Self::Seed) -> Self {
[00:04:49] 283 | |         StdRng(rngs::StdRng::from_seed(seed))
[00:04:49] 284 | |     }
[00:04:49]     | |_____^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Rng`
[00:04:49] error: aborting due to 28 previous errors
[00:04:49] 
[00:04:49] For more information about this error, try `rustc --explain E0277`.
[00:04:49] error: Could not compile `rand`.
[00:04:49] error: Could not compile `rand`.
[00:04:49] warning: build failed, waiting for other jobs to finish...
[00:04:58] error: failed to compile `cargo-vendor v0.1.22`, intermediate artifacts can be found at `/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools`
[00:04:58] Caused by:
[00:04:58]   build failed
[00:04:58] 
[00:04:58] 
[00:04:58] 
[00:04:58] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "install" "-j" "4" "--locked" "--color" "always" "--force" "--debug" "--vers" "0.1.22" "cargo-vendor"
[00:04:58] 
[00:04:58] 
[00:04:58] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test distcheck
[00:04:58] Build completed unsuccessfully in 0:00:56
---
travis_time:end:0060dd00:start=1559839411163599317,finish=1559839411170517280,duration=6917963
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:2f507960
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:070d5bd6
travis_time:start:070d5bd6
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:16bb9a40
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 6, 2019
@cuviper
Copy link
Member Author

cuviper commented Jun 6, 2019

Has this breakage been seen before? I don't think this change should affect rand's build...

@pietroalbini
Copy link
Member

A new rand version just released is broken, and it broke our CI.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2019
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Jun 6, 2019
bors added a commit that referenced this pull request Jun 6, 2019
[beta] Rollup backports

Rolled up:

* [beta] Permit unwinding through FFI by default #61569

Cherry-picked:

* upgrade rustdoc's `pulldown-cmark` to 0.5.2 #60802
* Fix overflowing literal lint in loops #61098
* Revert edition-guide toolstate override #61110
* Turn turbo 🐟 🍨 into an error #61189
* Bump hashbrown to 0.4.0 #61388
* Fix regression 61475 #61500

r? @ghost
@RalfJung
Copy link
Member

RalfJung commented Jun 7, 2019

A new rand version just released is broken, and it broke our CI.

So we don't have a lockfile for bootstrap? oO

@cuviper
Copy link
Member Author

cuviper commented Jun 7, 2019

So we don't have a lockfile for bootstrap? oO

I believe that's only true of the cargo install cargo-vendor, used to gather the full source tarball. But that command will be a cargo builtin soon!

@Mark-Simulacrum
Copy link
Member

cargo-vendor, actually, since it's installed via cargo install but currently, yes. It'll be fixed in the next cycle by inclusion of cargo vendor into Cargo itself.

@bors
Copy link
Contributor

bors commented Jun 7, 2019

⌛ Testing commit 32cd647 with merge 12f6a11173c7ddc132ab69b00cd12a5805096668...

@pietroalbini
Copy link
Member

@bors retry
Yielding priority to the beta rollup.

@rust-highfive
Copy link
Collaborator

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
Cloning into 'rust-lang/rust'...
travis_time:end:01b12395:start=1559942632933626808,finish=1559942638865666535,duration=5932039727
$ cd rust-lang/rust
$ git checkout -qf 12f6a11173c7ddc132ab69b00cd12a5805096668
fatal: reference is not a tree: 12f6a11173c7ddc132ab69b00cd12a5805096668
The command "git checkout -qf 12f6a11173c7ddc132ab69b00cd12a5805096668" failed and exited with 128 during .
Your build has been stopped.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Jun 7, 2019

⌛ Testing commit 32cd647 with merge ab54fa5aad7afe98e81014b913ada2e3084ec372...

@Centril
Copy link
Contributor

Centril commented Jun 7, 2019

@bors retry

bors added a commit that referenced this pull request Jun 7, 2019
[beta] Rollup backports

Rolled up:

* [beta] Permit unwinding through FFI by default #61569

Cherry-picked:

* upgrade rustdoc's `pulldown-cmark` to 0.5.2 #60802
* Fix overflowing literal lint in loops #61098
* Revert edition-guide toolstate override #61110
* Turn turbo 🐟 🍨 into an error #61189
* Bump hashbrown to 0.4.0 #61388
* Fix regression 61475 #61500

r? @ghost
@rust-highfive
Copy link
Collaborator

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
Cloning into 'rust-lang/rust'...
travis_time:end:37d32520:start=1559945621644027060,finish=1559945624110998066,duration=2466971006
$ cd rust-lang/rust
$ git checkout -qf ab54fa5aad7afe98e81014b913ada2e3084ec372
fatal: reference is not a tree: ab54fa5aad7afe98e81014b913ada2e3084ec372
The command "git checkout -qf ab54fa5aad7afe98e81014b913ada2e3084ec372" failed and exited with 128 during .
Your build has been stopped.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Jun 8, 2019

☔ The latest upstream changes (presumably #61602) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 8, 2019
bors added a commit that referenced this pull request Jul 12, 2019
[beta] Permit unwinding through FFI by default

This repeats #61569 for Rust 1.37, as #58794 is not yet resolved.

cc @rust-lang/release
r? @Mark-Simulacrum
@cuviper cuviper deleted the beta-1.36-no-unwind-abort branch April 3, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants