Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: refactor pr tools job skipping #65724

Merged
merged 3 commits into from
Oct 29, 2019
Merged

ci: refactor pr tools job skipping #65724

merged 3 commits into from
Oct 29, 2019

Commits on Oct 29, 2019

  1. ci: enable "run when submodule changes" with environment variables 

    We have a job in our CI (PR's x86_64-gnu-tools) that's supposed to run
only when a submodule is changed in the PR, and it works by having a
task at the start of the build that skips all the following tasks if the
condition isn't met.

Before this commit that task was gated with template parameters, which
is a unique feature of Azure Pipelines. To make our CI more generic this
commit switches the gate to use a simple environment variable plus a
condition, which should be supported on more CI providers.
    @pietroalbini
    pietroalbini committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    53be272 View commit details
    Browse the repository at this point in the history

  2. ci: extract job skipping logic into a script

    @pietroalbini
    pietroalbini committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    4fb8a9a View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from lzutao 

    Co-Authored-By: lzutao <taolzu@gmail.com>
    @pietroalbini @tesuji
    pietroalbini and tesuji authored Oct 29, 2019
    Configuration menu
    Copy the full SHA
    95ad6c3 View commit details
    Browse the repository at this point in the history