Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up check_consts now that new promotion pass is implemented #65839

Merged
merged 5 commits into from
Oct 27, 2019
Merged

Clean up check_consts now that new promotion pass is implemented #65839

merged 5 commits into from
Oct 27, 2019

Commits on Oct 26, 2019

  1. Make check_consts::Item work on non-const fns 

    This was originally only needed for validation, which is never run on
non-const `fn`s. The new promotion pass wants to use it, however.
    @ecstatic-morse
    ecstatic-morse committed Oct 26, 2019
    Configuration menu
    Copy the full SHA
    b2d021a View commit details
    Browse the repository at this point in the history

  2. Make Item fields pub

    @ecstatic-morse
    ecstatic-morse committed Oct 26, 2019
    Configuration menu
    Copy the full SHA
    8a462ff View commit details
    Browse the repository at this point in the history

  3. Deduplicate promote_consts::Validator and check_consts::Item

    @ecstatic-morse
    ecstatic-morse committed Oct 26, 2019
    Configuration menu
    Copy the full SHA
    748bbf2 View commit details
    Browse the repository at this point in the history

  4. Use is_lang_panic_fn from check_consts in promote_consts

    @ecstatic-morse
    ecstatic-morse committed Oct 26, 2019
    Configuration menu
    Copy the full SHA
    6538656 View commit details
    Browse the repository at this point in the history

  5. Remove QualifResolver abstraction 

    This is a relic from earlier attempts at dataflow-based const validation
that attempted to do promotion at the same time. rust-lang#63812 takes a
different approach: `IsNotPromotable` is no longer a `Qualif` and is
computed lazily instead of eagerly. As a result, there's no need for an
eager `TempPromotionResolver`, and we can use the only implementer of
`QualifResolver` directly instead of through a trait.
    @ecstatic-morse
    ecstatic-morse committed Oct 26, 2019
    Configuration menu
    Copy the full SHA
    b93cdbc View commit details
    Browse the repository at this point in the history