-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix emoji size to be congruent #67868
Conversation
@bors r+ rollup |
📌 Commit ba67dd5 has been approved by |
The emoji was specifically set to 1.5em in #38843 (comment). Are those reasons still valid as that's 3 years ago? (cc @Manishearth) |
@bors r- will approve once we get a good enough reason to change it |
The solution would maybe to add icons on other messages as well? |
@GuillaumeGomez Yes, that is good. Planning to do that later. But the big icon makes the box looks weird as for me and a little too big as you mentioned #38843 (comment). |
Yes, it was set to be bigger on purpose, it's being used as an icon, not text. |
@Manishearth then I supposed that this can be closed? But I still think the icon looks weird being next to the text. Maybe it can be out of the box? |
Perhaps. Open an issue to discuss it. I don't have strong opinions on this, but it should not be the size of the text, because it's supposed to catch your eye (but in a subtle way), so it needs to be bigger than the text. |
Original emoji looks exceptionally huge
Which looks weird compared to those without emoji
Updated to match font size and box
By the way, I think we should have an emoji for deprecation. I suggest coffin so far, later in another pull request.