Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emoji size to be congruent #67868

Closed
wants to merge 1 commit into from
Closed

Conversation

pickfire
Copy link
Contributor

@pickfire pickfire commented Jan 4, 2020

Original emoji looks exceptionally huge

2020-01-04-225119_824x120_scrot

Which looks weird compared to those without emoji

2020-01-04-225204_822x212_scrot

Updated to match font size and box

2020-01-04-225143_826x100_scrot

By the way, I think we should have an emoji for deprecation. I suggest coffin so far, later in another pull request.

@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 4, 2020

📌 Commit ba67dd5 has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 4, 2020
@kennytm
Copy link
Member

kennytm commented Jan 4, 2020

The emoji was specifically set to 1.5em in #38843 (comment). Are those reasons still valid as that's 3 years ago? (cc @Manishearth)

@Dylan-DPC-zz
Copy link

@bors r-

will approve once we get a good enough reason to change it

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 4, 2020
@Dylan-DPC-zz
Copy link

r? @GuillaumeGomez

@Dylan-DPC-zz Dylan-DPC-zz added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 4, 2020
@GuillaumeGomez
Copy link
Member

The solution would maybe to add icons on other messages as well?

@pickfire
Copy link
Contributor Author

pickfire commented Jan 5, 2020

@GuillaumeGomez Yes, that is good. Planning to do that later. But the big icon makes the box looks weird as for me and a little too big as you mentioned #38843 (comment).

@Manishearth
Copy link
Member

Yes, it was set to be bigger on purpose, it's being used as an icon, not text.

@pickfire
Copy link
Contributor Author

pickfire commented Jan 5, 2020

@Manishearth then I supposed that this can be closed? But I still think the icon looks weird being next to the text. Maybe it can be out of the box?

@Manishearth
Copy link
Member

Perhaps. Open an issue to discuss it. I don't have strong opinions on this, but it should not be the size of the text, because it's supposed to catch your eye (but in a subtle way), so it needs to be bigger than the text.

@Manishearth Manishearth closed this Jan 5, 2020
@pickfire pickfire deleted the emoji branch January 6, 2020 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants