Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pretty: print attrs in struct expr #68737

Merged
merged 1 commit into from
Feb 2, 2020
Merged

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Feb 1, 2020

Fixes #68710 by printing the attributes on struct expression fields.

r? @petrochenkov
cc @dtolnay

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 1, 2020
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Feb 1, 2020

📌 Commit 103e87c has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 1, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 1, 2020
pretty: print attrs in struct expr

Fixes rust-lang#68710 by printing the attributes on struct expression fields.

r? @petrochenkov
cc @dtolnay
@rust-highfive

This comment has been minimized.

@Centril
Copy link
Contributor Author

Centril commented Feb 1, 2020

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 1, 2020
@Centril
Copy link
Contributor Author

Centril commented Feb 1, 2020

--blessed the stringify!(...) fallout, @bors r=petrochenkov

@bors
Copy link
Contributor

bors commented Feb 1, 2020

📌 Commit 1f86cad9bbd584394bb42d748b6ecae38ce4e7ff has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 1, 2020
@rust-highfive

This comment has been minimized.

@bors

This comment has been minimized.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 1, 2020
@Centril
Copy link
Contributor Author

Centril commented Feb 2, 2020

Pared this back down to just the attribute cause I couldn't figure out how to get pretty printing to be pretty. @bors r=petrochenkov

@bors
Copy link
Contributor

bors commented Feb 2, 2020

📌 Commit 00f0b0c has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 2, 2020
@bors
Copy link
Contributor

bors commented Feb 2, 2020

⌛ Testing commit 00f0b0c with merge cef6894...

bors added a commit that referenced this pull request Feb 2, 2020
pretty: print attrs in struct expr

Fixes #68710 by printing the attributes on struct expression fields.

r? @petrochenkov
cc @dtolnay
@bors
Copy link
Contributor

bors commented Feb 2, 2020

☀️ Test successful - checks-azure
Approved by: petrochenkov
Pushing cef6894 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 2, 2020
@bors bors merged commit 00f0b0c into rust-lang:master Feb 2, 2020
@Centril Centril deleted the fix-68710 branch February 2, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field attributes lost in proc macro input
4 participants