-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New zeroed slice #75171
New zeroed slice #75171
Conversation
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
r? @SimonSapin |
@amosonn: 🔑 Insufficient privileges: not in try users |
1 similar comment
@amosonn: 🔑 Insufficient privileges: not in try users |
b2eebb5
to
f75f492
Compare
☔ The latest upstream changes (presumably #75174) made this pull request unmergeable. Please resolve the merge conflicts. |
a41071d
to
ab204c5
Compare
r? @Amanieu |
@bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit ab204c5 with merge c7bc9915d37800e60ddf1d2cc573758c724395c3... |
@bors try |
⌛ Trying commit 5aba816 with merge f3a9871a4972d9c4fe07f70e3e5aa63d6bdb6577... |
☀️ Try build successful - checks-actions, checks-azure |
Queued f3a9871a4972d9c4fe07f70e3e5aa63d6bdb6577 with parent de521cb, future comparison URL. |
Finished benchmarking try commit (f3a9871a4972d9c4fe07f70e3e5aa63d6bdb6577): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
@bors r+ rollup- |
📌 Commit 5aba816 has been approved by |
☀️ Test successful - checks-actions, checks-azure |
Add to #63291 the methods
as suggested in #63291 (comment) .
Also optimize
{Rc, Arc}::new_zeroed
to usealloc_zeroed
, otherwise they are no more efficient than usingnew_uninit
and zeroing the memory manually (which was the original implementation).