impl Pattern for char array #86336

camsteffen · 2021-06-15T19:53:19Z

rust-highfive · 2021-06-15T19:53:22Z

(rust-highfive has picked a reviewer for you, use r? to override)

library/core/src/str/pattern.rs

scottmcm · 2021-06-21T19:48:26Z

library/core/src/str/pattern.rs

@@ -601,6 +608,17 @@ where
    }
 }

+impl<const N: usize> MultiCharEq for &[char; N] {


This might be a silly question, but why for &[char; N] instead of for [char; N]?

Actually that's what I started with, but then I figured this is more flexible/performant for large arrays. Definitely open to discussion on that. Maybe add both?

I think you do want the reference to solve those bugs where one intends to write a literal &[char] slice pattern, but it's really &[char; N].

I think both -- ['o', 'l'] for the simple case, and &[...] for the case cuviper mentions.

(I might just delegate both to the impl for slices, though, if there's an easy way to do that.)

Okay, added both. Unfortunately lifetimes force a lot of separate structs and impls to satisfy into_searcher.

library/core/src/str/pattern.rs

dtolnay · 2021-07-26T21:18:03Z

@rust-lang/libs-api:
@rfcbot fcp merge

This PR adds impl<'a, const N: usize> Pattern<'a> for [char; N] and impl<'a, 'b, const N: usize> Pattern<'a> for &'b [char; N], which allows str::find and similar methods based on Pattern to work as:

"...".find([' ', '\r', '\n'])
// or:
"...".find(&[' ', '\r', '\n'])

whereas before, due to #39511, it would have had to be written as:

"...".find(&[' ', '\r', '\n'][..])

rfcbot · 2021-07-26T21:18:04Z

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2021-07-28T14:02:18Z

🔔 This is now entering its final comment period, as per the review above. 🔔

camsteffen · 2021-07-28T21:14:22Z

Squashed a fixup commit

rfcbot · 2021-08-07T14:04:39Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

camelid · 2021-10-08T00:26:55Z

It looks like this PR just needs a final review now that FCP has finished.

camelid · 2021-10-08T00:27:50Z

Should relnotes be added since IIUC this is insta-stable (even though Pattern itself is not stable)?

camsteffen · 2021-10-08T21:35:56Z

@dtolnay you approved the changes in Github. Is that grounds to r=yoself?

camelid · 2021-10-08T22:03:57Z

(Adding relnotes since this is insta-stable.)

joshtriplett · 2021-10-30T23:06:55Z

@bors r+

bors · 2021-10-30T23:06:56Z

📌 Commit 28f7890 has been approved by joshtriplett

bors · 2021-10-31T15:45:43Z

⌛ Testing commit 28f7890 with merge c7e4740...

bors · 2021-10-31T18:57:07Z

☀️ Test successful - checks-actions
Approved by: joshtriplett
Pushing c7e4740 to master...

rust-timer · 2021-10-31T20:29:48Z

Finished benchmarking commit (c7e4740): comparison url.

Summary: This change led to small relevant regressions 😿 in compiler performance.

Small regression in instruction counts (up to 0.6% on full builds of deeply-nested-async)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

pnkfelix · 2021-11-02T19:54:27Z

visiting for triage.

The only benchmarks that regressed did so by a small amount, percentage wise 0.2-0.6%; the benchmarks that did regress in that fashion are deeply-nested-async, helloworld, unify-linearly.

I am surprised that this change caused even this minor regression, but I don't think its worth investing effort trying to figure out why, unless someone wants to take it on as a self-educating exercise.

@rustbot label: +perf-regression-triaged

rust-highfive assigned dtolnay Jun 15, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 15, 2021

camsteffen commented Jun 15, 2021

View reviewed changes

library/core/src/str/pattern.rs Outdated Show resolved Hide resolved

scottmcm added needs-fcp This change is insta-stable, so needs a completed FCP to proceed. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jun 21, 2021

scottmcm reviewed Jun 21, 2021

View reviewed changes

library/core/src/str/pattern.rs Show resolved Hide resolved

crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2021

dtolnay approved these changes Jul 26, 2021

View reviewed changes

rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Jul 28, 2021

camsteffen added 2 commits July 28, 2021 16:13

impl Pattern for char array

5e4f212

Add char array without ref Pattern impl

28f7890

camsteffen force-pushed the char-array-pattern branch from c26aed0 to 28f7890 Compare July 28, 2021 21:14

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Aug 7, 2021

apiraino removed the to-announce Announce this issue on triage meeting label Aug 26, 2021

camelid added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 8, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 31, 2021

bors merged commit c7e4740 into rust-lang:master Oct 31, 2021

rustbot added this to the 1.58.0 milestone Oct 31, 2021

jplatte mentioned this pull request Oct 31, 2021

Data to add jplatte/caniuse.rs#16

Open

65 tasks

rustbot added the perf-regression Performance regression. label Oct 31, 2021

rustbot added the perf-regression-triaged The performance regression has been triaged. label Nov 2, 2021

epage mentioned this pull request Apr 18, 2022

Failed to install cargo-edit 0.9.0 with Rust 1.60 for Ubuntu 20.04.4 LTS (Multipass) killercup/cargo-edit#695

Closed

cuviper mentioned this pull request Jan 26, 2024

impl Pattern for [char; N] and &[char; N] rayon-rs/rayon#1117

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

impl Pattern for char array #86336

impl Pattern for char array #86336

camsteffen commented Jun 15, 2021

rust-highfive commented Jun 15, 2021

scottmcm Jun 21, 2021

camsteffen Jun 21, 2021

cuviper Jun 21, 2021

scottmcm Jun 21, 2021

camsteffen Jun 22, 2021 •

edited

Loading

dtolnay commented Jul 26, 2021

rfcbot commented Jul 26, 2021 •

edited by joshtriplett

Loading

rfcbot commented Jul 28, 2021

camsteffen commented Jul 28, 2021

rfcbot commented Aug 7, 2021

camelid commented Oct 8, 2021

camelid commented Oct 8, 2021

camsteffen commented Oct 8, 2021

camelid commented Oct 8, 2021

joshtriplett commented Oct 30, 2021

bors commented Oct 30, 2021

bors commented Oct 31, 2021

bors commented Oct 31, 2021

rust-timer commented Oct 31, 2021

pnkfelix commented Nov 2, 2021

impl Pattern for char array #86336

impl Pattern for char array #86336

Conversation

camsteffen commented Jun 15, 2021

rust-highfive commented Jun 15, 2021

scottmcm Jun 21, 2021

Choose a reason for hiding this comment

camsteffen Jun 21, 2021

Choose a reason for hiding this comment

cuviper Jun 21, 2021

Choose a reason for hiding this comment

scottmcm Jun 21, 2021

Choose a reason for hiding this comment

camsteffen Jun 22, 2021 • edited Loading

Choose a reason for hiding this comment

dtolnay commented Jul 26, 2021

rfcbot commented Jul 26, 2021 • edited by joshtriplett Loading

rfcbot commented Jul 28, 2021

camsteffen commented Jul 28, 2021

rfcbot commented Aug 7, 2021

camelid commented Oct 8, 2021

camelid commented Oct 8, 2021

camsteffen commented Oct 8, 2021

camelid commented Oct 8, 2021

joshtriplett commented Oct 30, 2021

bors commented Oct 30, 2021

bors commented Oct 31, 2021

bors commented Oct 31, 2021

rust-timer commented Oct 31, 2021

pnkfelix commented Nov 2, 2021

camsteffen Jun 22, 2021 •

edited

Loading

rfcbot commented Jul 26, 2021 •

edited by joshtriplett

Loading