libstd: Resume inlining floating intrinsics #9479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were accidentally marked as #[inline] #[inline(never)] which ended up never inlining them. This change actually resumes inlining them in the sense that LLVM sees the intrinsic as directly called.
|
Hmm, perhaps this just needs more discussion about our stack strategy... |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 6, 2022
[`manual_assert`]: Preserve comments in the suggestion close rust-lang/rust-clippy#7730 changelog: [`manual_assert`]: Preserve comments in the suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were accidentally marked as #[inline] #[inline(never)] which ended up never
inlining them. This change actually resumes inlining them in the sense that LLVM
sees the intrinsic as directly called.