Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auto traits in rustdoc #95069

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Fix auto traits in rustdoc #95069

merged 2 commits into from
Mar 24, 2022

Conversation

GuillaumeGomez
Copy link
Member

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 18, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 18, 2022
@GuillaumeGomez
Copy link
Member Author

@oli-obk told me they would take a look when they can so assigning it to them.

r? @oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned Aaron1011 Mar 18, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Mar 23, 2022

I'm not confident allow_negative_impls needs to exist at all, but this PR doesn't make things worse and it's only used for rustdoc

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 23, 2022

📌 Commit 7c53ae0 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 23, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2022
@bors
Auto merge of rust-lang#95250 - matthiaskrgr:rollup-ma4zl69, r=matthi…
37b55c8 
…askrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#94249 (Better errors when a Copy impl on a Struct is not self-consistent)
 - rust-lang#95069 (Fix auto traits in rustdoc)
 - rust-lang#95221 (interpret/memory: simplify check_and_deref_ptr)
 - rust-lang#95225 (remove `[async output]` from `impl Future` pretty-printing)
 - rust-lang#95238 (Stop emitting E0026 for struct enums with underscores)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0c79c86 into rust-lang:master Mar 24, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 24, 2022
@GuillaumeGomez GuillaumeGomez deleted the auto-traits-rustdoc branch March 24, 2022 10:29
@Alexendoo Alexendoo mentioned this pull request Mar 25, 2022
Closed
@GuillaumeGomez GuillaumeGomez mentioned this pull request Mar 26, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 28, 2022
@bors
Auto merge of rust-lang#95333 - GuillaumeGomez:auto-trait-perf-issue,…
3badf5c 
… r=oli-obk

Fix perf issue for auto trait selection

Follow-up of rust-lang#95069 which fixes the perf issue introduced by it.

r? `@oli-obk`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.

Rustdoc incorrectly shows blanket impls with Send contraints on !Send types
6 participants
@GuillaumeGomez @oli-obk @bors @Aaron1011 @rust-highfive @rustbot