Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retire ItemLikeVisitor trait #96825

Merged
merged 30 commits into from
May 17, 2022
Merged

Retire ItemLikeVisitor trait #96825

merged 30 commits into from
May 17, 2022

Commits on May 13, 2022

  1. Remove CheckConstTraitVisitor 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    bd2b210 View commit details
    Browse the repository at this point in the history

  2. replace usage of visit_item_likes_in_modules with hir_module_items query 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    0026034 View commit details
    Browse the repository at this point in the history

  3. remove LifeSeeder 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    52f833a View commit details
    Browse the repository at this point in the history

  4. remove DiagnosticItemCollector 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    dab0e75 View commit details
    Browse the repository at this point in the history

  5. remove ItemLikeVisitor impl for EntryContext 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    fb73ae2 View commit details
    Browse the repository at this point in the history

  6. optimize find_item to fetch Item only when needed 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    b1f0209 View commit details
    Browse the repository at this point in the history

  7. remove OuterVisitor 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    0ef16fe View commit details
    Browse the repository at this point in the history

  8. remove LayoutTest 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    45c37da View commit details
    Browse the repository at this point in the history

  9. remove CollectPrivateImplItemsVisitor 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    0a029e2 View commit details
    Browse the repository at this point in the history

  10. check def_kind before fetching item 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    90685c6 View commit details
    Browse the repository at this point in the history

  11. replace hir().def_kind for def_kind query in rustc_passes 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    eea16de View commit details
    Browse the repository at this point in the history

  12. remove TraitVisitor 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    e8ef5bf View commit details
    Browse the repository at this point in the history

  13. remove Visitor impl for PrivateItemsInPublicInterfacesChecker 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    e166409 View commit details
    Browse the repository at this point in the history

  14. add module_items 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    cdba1dc View commit details
    Browse the repository at this point in the history

  15. remove TestItemNamesVisitor 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    52d721c View commit details
    Browse the repository at this point in the history

  16. remove DebuggerVisualizerCollector 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    885b90b View commit details
    Browse the repository at this point in the history

  17. remove HirVisitor 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    0b7dd95 View commit details
    Browse the repository at this point in the history

  18. remove ItemLikeVisitor and DeepVisitor 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    93616dd View commit details
    Browse the repository at this point in the history

  19. update comments about visitor strategy 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    7e44078 View commit details
    Browse the repository at this point in the history

  20. rename visit item-like methods 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    f975d05 View commit details
    Browse the repository at this point in the history

  21. change back to using tcx.hir() visit-item method 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    2e98879 View commit details
    Browse the repository at this point in the history

  22. update rustdoc code to use new method name 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    cad1fd2 View commit details
    Browse the repository at this point in the history

  23. change for_each_module's parameter to FnMut 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    df11942 View commit details
    Browse the repository at this point in the history

  24. use for_each_module instead of iterating over Item's 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    91223ac View commit details
    Browse the repository at this point in the history

  25. avoid converting to DefId from LocalDefId when using query 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    433a5f1 View commit details
    Browse the repository at this point in the history

  26. remove unnecessary methods from HirIdValidator 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    17e86d9 View commit details
    Browse the repository at this point in the history

  27. remove redundant branch 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 13, 2022
    Configuration menu
    Copy the full SHA
    f1c256d View commit details
    Browse the repository at this point in the history

Commits on May 14, 2022

  1. avoid fetching HIR when handling Impl assoc items 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 14, 2022
    Configuration menu
    Copy the full SHA
    959636d View commit details
    Browse the repository at this point in the history

  2. use opt_item_name to pattern match items with names 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 14, 2022
    Configuration menu
    Copy the full SHA
    f77658b View commit details
    Browse the repository at this point in the history

  3. allocate string only when error will be emitted 

    Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
    @kckeiks
    kckeiks committed May 14, 2022
    Configuration menu
    Copy the full SHA
    48fd666 View commit details
    Browse the repository at this point in the history