Add support for embedding pretty printers via #[debugger_visualizer] attribute
#97028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
ridwanabdillahi
force-pushed
the
pretty-printer
branch
from
287cc32
to
f8cfc2d
Compare
This comment has been minimized.
This comment has been minimized.
luqmana
reviewed
May 14, 2022
|
Hey! Looks like someone invited me to this issue. |
|
@givebk-bot !give @ridwanabdillahi $1 thanks for your work! |
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #96825) made this pull request unmergeable. Please resolve the merge conflicts. |
There was a problem hiding this comment.
Thanks for the PR, @ridwanabdillahi! It looks very good already (it's great that it extends testing), but we'll need to resolve the issue around the linkage of __rustc_debug_gdb_scripts_section__ somehow (see below).
src/test/debuginfo/auxiliary/dependency-with-embedded-visualizers.py
Outdated
Show resolved
Hide resolved
src/test/debuginfo/auxiliary/dependency-with-embedded-visualizers.py
Outdated
Show resolved
Hide resolved
ridwanabdillahi
force-pushed
the
pretty-printer
branch
from
bf66057
to
3be81f7
Compare
This comment has been minimized.
This comment has been minimized.
|
That last commit still looks a bit funny 😀 Maybe the rebase didn't quite work. |
…zer]` attribute. Add tests for embedding pretty printers and update documentation. Ensure all error checking for `#[debugger_visualizer]` is done up front and not when the `debugger_visualizer` query is run. Clean up potential ODR violations when embedding pretty printers into the `__rustc_debug_gdb_scripts_section__` section. Respond to PR comments and update documentation.
ridwanabdillahi
force-pushed
the
pretty-printer
branch
from
f7b20e6
to
ab1f8ed
Compare
There was a problem hiding this comment.
Thanks, @ridwanabdillahi, looks great!
Please address the error message issue mentioned below, then this should be ready to go.
|
Thanks, @ridwanabdillahi! This looks good to me now. @bors r+ |
|
📌 Commit 7ac62ce has been approved by |
bors
added
S-waiting-on-bors
5 tasks
|
@rustbot label +F-debugger_visualizer |
|
Tracking issue for the feature being implemented by this PR: rust-lang/rust#95939 |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 28, 2022
…ichaelwoerister Add support for embedding pretty printers via `#[debugger_visualizer]` attribute Initial support for [RFC 3191](rust-lang/rfcs#3191) in PR rust-lang#91779 was scoped to supporting embedding NatVis files using a new attribute. This PR implements the pretty printer support as stated in the RFC mentioned above. This change includes embedding pretty printers in the `.debug_gdb_scripts` just as the pretty printers for rustc are embedded today. Also added additional tests for embedded pretty printers. Additionally cleaned up error checking so all error checking is done up front regardless of the current target. RFC: rust-lang/rfcs#3191
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 29, 2022
…laumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#96950 (Add regression test for rust-lang#96395) - rust-lang#97028 (Add support for embedding pretty printers via `#[debugger_visualizer]` attribute) - rust-lang#97478 (Remove FIXME on `ExtCtxt::fn_decl()`) - rust-lang#97479 (Make some tests check-pass) - rust-lang#97482 (ptr::invalid is not equivalent to a int2ptr cast) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
🎁 Hey @ridwanabdillahi, you have just received U$ 1 from @nthypes!
@nthypes thanks for your support! ❤️
@ridwanabdillahi, you can check your balance at https://givebk.io.
═══
(powered by https://givebk.io)
ID: cb7af84b-110f-4e0b-99fb-8e059c1419c9
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support for RFC 3191 in PR #91779 was scoped to supporting embedding NatVis files using a new attribute. This PR implements the pretty printer support as stated in the RFC mentioned above.
This change includes embedding pretty printers in the
.debug_gdb_scriptsjust as the pretty printers for rustc are embedded today. Also added additional tests for embedded pretty printers. Additionally cleaned up error checking so all error checking is done up front regardless of the current target.RFC: rust-lang/rfcs#3191