Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Canonical queries" section doesn't explain canonical queries #1527

Closed
jyn514 opened this issue Dec 8, 2022 · 3 comments · Fixed by #1532
Closed

"Canonical queries" section doesn't explain canonical queries #1527

jyn514 opened this issue Dec 8, 2022 · 3 comments · Fixed by #1532

Comments

@jyn514
Copy link
Member

jyn514 commented Dec 8, 2022

https://rustc-dev-guide.rust-lang.org/traits/canonical-queries.html doesn't mention the word "canonical" once. It looks like the docs got deleted in #679. @crlf0710 do you have time to add these back? Canonicalization is important and still happens in rustc, not chalk.

https://github.com/rust-lang/rust/blob/e940f845be13ff37d4ba28df5f40d74e5b0895a0/compiler/rustc_trait_selection/src/traits/mod.rs#L103-L114
@spastorino
Copy link
Member

cc @lcnr

@crlf0710 crlf0710 mentioned this issue Dec 17, 2022
Merged
@crlf0710
Copy link
Member

Submitted #1532

@jyn514
Copy link
Member Author

jyn514 commented Dec 17, 2022

Thank you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add back the canonicalization chapter. crlf0710/rustc-dev-guide
3 participants
@spastorino @crlf0710 @jyn514