html5ever is broken

[nnethercote]

From https://perf.rust-lang.org/status.html:

error: macro-expanded `macro_export` macros from the current crate cannot be referred to by absolute paths
  --> /home/alex/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/string_cache-0.2.29/src/lib.rs:71:13
   |
71 |     pub use atom;
   |             ^^^^
   |
note: the macro is defined here
  --> /tmp/.tmp7hXhhV/target/debug/build/string_cache-85a0b96525ad2556/out/atom_macro.rs:2:1
   |
2  | / macro_rules! atom {
3  | | (\"sdev\") => { $crate::Atom { unsafe_data: 0x2 } };
4  | | (\"onstart\") => { $crate::Atom { unsafe_data: 0x100000002 } };
5  | | (\"overflow\") => { $crate::Atom { unsafe_data: 0x200000002 } };
...  |
127| | (\"stroke-miterlimit\") => { $crate::Atom { unsafe_data: 0x4f400000002 } };
127| | }
   | |_^

@alexcrichton: can you advise on how to fix this?

[petrochenkov]

Duplicate of rust-lang/rust#53495

[nnethercote]

@alexcrichton: is closing the right thing to do here? It seems like eventually the html5ever benchmark's code is going to have to change, right?

[alexcrichton]

Oh I just closed in favor of the duplicate, rust-lang/rust#53495

[nnethercote]

There are two ways this issue could be fixed:
(a) rustc is modified somehow;
(b) the html5ever benchmark is modified somehow.

My impression is that (a) is not sufficient/appropriate, and that (b) will be necessary. In which case, leaving this issue open is the right thing to do. Make sense?

[Mark-Simulacrum]

That issue is tracking this same problem though?

[nnethercote]

Will fixing the problem require changes to the rust-lang repo? If so, then the tracking issue should be on the rust-lang repo.

Alternatively: will fixing the problem require changes to the rustc-perf repo? If so, then the tracking issue should be on the rustc-perf repo.

My understanding is that the latter case is true here.

[Mark-Simulacrum]

Oh, I completely missed this is on a different repository. Yes, this should be tracked here.

[Mark-Simulacrum]

We've since fixed this -- html5ever compiles today.