Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raw identifiers in use statements affect the ordering #3791

Closed
ChrisGreenaway opened this issue Sep 11, 2019 · 2 comments
Closed

Raw identifiers in use statements affect the ordering #3791

ChrisGreenaway opened this issue Sep 11, 2019 · 2 comments
Labels
1x-backport:pending Fixed/resolved in source but not yet backported to a 1x branch and release a-imports `use` syntax good first issue Issues up for grabs, also good candidates for new rustfmt contributors

Comments

@ChrisGreenaway
Copy link

For example:

use websocket::r#async::futures::Stream;
use websocket::client::ClientBuilder;
use websocket::result::WebSocketError;

gets reformatted as:

use websocket::client::ClientBuilder;
use websocket::r#async::futures::Stream;
use websocket::result::WebSocketError;
@topecongiro topecongiro added a-imports `use` syntax good first issue Issues up for grabs, also good candidates for new rustfmt contributors labels Sep 13, 2019
@calebcartwright calebcartwright mentioned this issue Sep 14, 2019
Merged
@scampi
Copy link
Contributor

scampi commented Sep 27, 2019

fixed in rustfmt-2.0 branch

@scampi scampi closed this as completed Sep 27, 2019
@calebcartwright calebcartwright added the 1x-backport:pending Fixed/resolved in source but not yet backported to a 1x branch and release label Oct 30, 2021
@calebcartwright
Copy link
Member

Note that this is still need of being backported, but with the version gates applied

@calebcartwright calebcartwright mentioned this issue Jun 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1x-backport:pending Fixed/resolved in source but not yet backported to a 1x branch and release a-imports `use` syntax good first issue Issues up for grabs, also good candidates for new rustfmt contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@scampi @calebcartwright @ChrisGreenaway @topecongiro