Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Do not touch module with #![rustfmt::skip] (#4297) #5065

Closed
ytmimi opened this issue Nov 5, 2021 · 0 comments · Fixed by #5094
Closed

Backport: Do not touch module with #![rustfmt::skip] (#4297) #5065

ytmimi opened this issue Nov 5, 2021 · 0 comments · Fixed by #5094

Comments

@ytmimi
Copy link
Contributor

ytmimi commented Nov 5, 2021

Summary

When working to fix issue #5033 in PR #5035 I proposed a solution to extended the span of the root module to include all content within the file (including trailing comments).

The PR was accepted because rustfmt should have a view of the entire file, but @calebcartwright and I agreed that the preferred solution would be to ignore files completely if they contain the #![rustfmt::skip] attribute.

#4297 introduces code that correctly skips files marked with the #![rustfmt::skip] attribute, but we need to review the changes before we can backport them into 1.x

@ytmimi ytmimi added the 1x-backport:pending Fixed/resolved in source but not yet backported to a 1x branch and release label Nov 5, 2021
@ytmimi ytmimi added 1x-backport:completed a-rustfmt::skip and removed 1x-backport:pending Fixed/resolved in source but not yet backported to a 1x branch and release labels Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant