Don't merge crates when imports_granularity="Module"
#6192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When merging imports using `imports_granularity="Module"`, individual
crate imports should get their own `use` statement on a new line.
```
// Before this commit:
use {library1, library2 as lib2, library3};
// After this commit:
use library1;
use library2 as lib2;
use library3;
```
Fixes: rust-lang#6191
|
I haven't really reviewed this, but I quickly tested out this branch on this input: use library1;
use library1::one;
use library1::two;
use library2 as lib2;
use library3;which produced this output: use library1;
use library1::{one, two};
use library2 as lib2;
use library3;It seems reasonable to me, but I'm wondering if it would be expected to produce the following instead: use library1::{self, one, two};
use library2 as lib2;
use library3; |
|
Thanks for trying it out!
I personally would also prefer the second output rather than the first, but I think this is out of scope for this PR because I think aliasing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging imports using
imports_granularity="Module", individual crate imports should get their ownusestatement on a new line.Fixes: #6191