Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message when module resolution failed #4198

Merged
merged 2 commits into from
May 24, 2020
Merged

Improve error message when module resolution failed #4198

merged 2 commits into from
May 24, 2020

Conversation

topecongiro
Copy link
Contributor

Close #4160.

calebcartwright
calebcartwright approved these changes May 24, 2020
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (and should be a big help in resolving #4126 too)

@topecongiro topecongiro merged commit 8842c43 into rust-lang:master May 24, 2020
@topecongiro topecongiro deleted the issue-4160 branch May 24, 2020 23:34
bradleypmartin pushed a commit to bradleypmartin/rustfmt that referenced this pull request May 25, 2020
@topecongiro
Improve error message when module resolution failed (rust-lang#4198)
35121ea
@calebcartwright calebcartwright mentioned this pull request Jun 12, 2020
Merged
@karyon
Copy link
Contributor

karyon commented Oct 27, 2021

backported in #4253

@camsteffen camsteffen mentioned this pull request Jan 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
1x-backport:completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error writing files: io error: Failed to find module foo in "/tmp/foo/src" None
3 participants
@topecongiro @karyon @calebcartwright