Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump rustfmt 1.x rustc-ap* crates to v644 #4253

Merged
merged 8 commits into from
Jun 13, 2020

Conversation

calebcartwright
Copy link
Member

@calebcartwright calebcartwright commented Jun 11, 2020

Refs rust-lang/rust#73200, rustfmt 1.x pair to #4252.

There's one last parser bug which has been fixed in source, but that I want to also backport to rustfmt 1.x as part of this

@calebcartwright
Copy link
Member Author

Believe some of the CI failures are likely related to rust-lang/cargo#8351

For example:

Caused by:

  unable to get packages from source

Caused by:

  failed to parse manifest at `/home/travis/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/lalrpop-0.19.0/Cargo.toml`

Caused by:

  readme file with name '\''../README.md'\'' was not found'

+[[ error: failed to download `lalrpop v0.19.0`

Caused by:

  unable to get packages from source

Caused by:

  failed to parse manifest at `/home/travis/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/lalrpop-0.19.0/Cargo.toml`

Caused by:

  readme file with name '../README.md' was not found =~ build failed ]]

+[[ error: failed to download `lalrpop v0.19.0`

@calebcartwright calebcartwright changed the title [wip] bump rustfmt 1.x rustc-ap* crates to v644 bump rustfmt 1.x rustc-ap* crates to v644 Jun 12, 2020
Copy link
Contributor

@topecongiro topecongiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR with some backportings! LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants