Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The complete profile really should warn the user #2136

Closed
kinnison opened this issue Nov 20, 2019 · 6 comments
Closed

The complete profile really should warn the user #2136

kinnison opened this issue Nov 20, 2019 · 6 comments

Comments

@kinnison
Copy link
Contributor

We have a lot of people who want to install complete despite it really being for Rust developers rather than those who develop with Rust.

As a stop-gap, since removing complete would be a bit of a pain, it'd be useful if rustup could warn whenever complete is used to install a toolchain. That'd be fairly lightweight and could mitigate a lot of issues which might otherwise be raised.

This should be a very easy first issue for someone, and I'd be happy to mentor them on #wg-rustup on our discord.

@kinnison
Copy link
Contributor Author

If you wish to take on this work, please state so on this issue, and then find me on Discord to discuss it. That way we won't have multiple people trying to solve the same thing at the same time. Thanks.

@kinnison
Copy link
Contributor Author

In addition, https://github.com/rust-lang/rustup#profiles misrepresents the complete profile a little as being of use for general developers. We probably need to fix that as part of any PR to resolve this issue.

@Stupremee
Copy link
Member

I can take care of that. @kinnison I can ping you in discord

@Stupremee
Copy link
Member

I guess this can be closed now

@kinnison
Copy link
Contributor Author

Closed in #2138

@svend
Copy link

svend commented Feb 5, 2020

I found https://github.com/rust-lang/rustup#profiles confusing. I picked the complete profile, since I wanted IDE support out of the box.

The complete profile includes all the components available through rustup, including miri and IDE integration tools (rls and rust-analysis).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants