-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP proxy support #401
Comments
Considering the typical We just need to pull the config from the environment and parse it, as a reference here's how curl does it. |
This won't be in the initial release? |
Since the switch to curl, this is actually supported in the same standard method that curl supports it now (e.g. standard env vars) |
Solved by #532? |
@lilianmoraru I don't quite consider it solved yet. Two things:
Unfortunately I still don't know much myself about how to use this feature. |
curl environment variables: https://curl.haxx.se/docs/manpage.html heading "ENVIRONMENT":
hyper doesn't look for any environment variables. rustup would need to look for them, and enable the proxy settings on the Client itself. |
Thanks @seanmonstar. The hyper backend for rustup defines a function for the |
Ah, well I didn't copy the whole section. There is an Here's the rest of the section:
|
The hyper backend now uses the same env vars as curl. Just waiting on docs. |
Done. Thanks @inejge ! |
With hyper 0.9.2 you can call
Client::with_http_proxy(host, port)
to set up the HTTP proxy.I'm not sure how I want to implement this yet, whether there are standard ways to indicate a proxy should be used or not. Whatever the solution it needs to work during the initial install as well as after installation.
cc #344
cc @seanmonstar
The text was updated successfully, but these errors were encountered: