Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate_config should not run on closed PRs #1802

Closed
ehuss opened this issue May 2, 2024 · 0 comments · Fixed by #1804
Closed

validate_config should not run on closed PRs #1802

ehuss opened this issue May 2, 2024 · 0 comments · Fixed by #1804
Assignees

Comments

@ehuss
Copy link
Contributor

ehuss commented May 2, 2024

The validate_config handler seems to trigger on events hitting old, closed PRs. It loads the triagebot.toml from the PR itself, which might be very old, and fail. rust-lang/rust#73206 (comment) is an example.

I think at a minimum it probably should not run on closed PRs. I'm not sure if it should ignore other events, but that seems like a start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant