Configure team nominate label in prioritization alerts on Zulip

[apiraino]

This patch tries to customize the prioritization Zulip notification (I-{team}-nominated) according to the team labels on the issue.

It's not complete, there are some cases not covered but I didn't feel complicating too much the logic.

And this is a brainstoming for @fmease that suggested doing so. Feel free to own this patch and bring it to completion (unsure you have permissions on this repo) or suggest how you would like the implementation to be.

This patch completes rust-lang/rust#119959 (review)

Thanks!

[apiraino]

hey @fmease I was looking into completing this small change.

wdyt? Does it look like what you wanted to accomplish?

[fmease]

It definitely does what I had envisioned, thanks! 😊 The major issue I see is that this PR adds very rust-lang/rust-specific logic to triagebot. While triagebot still contains a lot of things specific to rust-lang/rust, I think the general vision for this bot is to move anything repo-specific to configs & to make it repo-agnostic.

cc @WaffleLapkin

[fmease]

And I really don't know how one would best abstract over this feature and make it configurable.
If the maintainers of this repo are fine with merging this as is, then that's awesome, if they aren't we need to change the approach.

@Mark-Simulacrum, what do you think?

[WaffleLapkin]

@fmease all zulip stuff is highly specific to rust-lang. so while I'd like it to be more configurable, this specific change does not really change much.

[apiraino]

The major issue I see is that this PR adds very rust-lang/rust-specific logic to triagebot.

That's true, I agree. However making it really generic is beyond the time I want to allocate on implementing this change (see also my first comment). So if it's not that bad and it's accepted, great, otherwise I'll have to drop the mic on this 😄

[fmease]

small stylistic nits, not blocking. sorry, forgot to submit a code review earlier.

[apiraino]

applied the suggested nits!

thanks @fmease for your time :)

[fmease]

needs rebase

[ehuss]

Thanks! I'm going to go ahead and merge based on previous reviews, and since this seems pretty simple.

@apiraino Do you mind following up and post an update to the documentation at https://github.com/rust-lang/rust-forge/blob/master/src/triagebot/zulip-notifications.md to add a brief mention of this?