game_activity: Fix pointer_index() always returning 0
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
approved these changes
May 24, 2023
There was a problem hiding this comment.
I agree, this is also what we do in the NDK (and these APIs look pretty much identical)
Perhaps @rib intended to use self.action on the next line, and instead use action to validate whether the MOTION_ACCESS in one of Up/Down/PointerUp/PointerDown?
MarijnS95
changed the title
pointer_index() always returning 0
|
Thanks, yeah this looks wrong. I doubt I was planning to validate the action and probably just made a mistake at the time, oops. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given
AMOTION_EVENT_ACTION_MASKis 0xff andAMOTION_EVENT_ACTION_POINTER_INDEX_MASKis 0xff00, this function always returns 0. Looks like ANDing withAMOTION_EVENT_ACTION_MASKshould be removed.