Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM clibs with u8 #351

Open
JBenda opened this issue Nov 28, 2022 · 4 comments
Open

ARM clibs with u8 #351

JBenda opened this issue Nov 28, 2022 · 4 comments

Comments

@JBenda
Copy link

JBenda commented Nov 28, 2022

As referenced here on ARM architectures (e.g. Raspberry Pi) the cLibs uses u8 as pointer type instead of i8.
This is a problem in flags.rs, where the implementations of as_ptr() are not platform-agnostic.

If someone tells me how this project recognize the default data pointer type, I could open a PR.

Or if there is already a flag that I should have set, please let me know, and I apologize for bothering you.

Hotfix: replace return type of each as_ptr function in lex/sr/flags.rs with c_char and define it to your platform needs.

@Dirreke
Copy link

Dirreke commented Jan 21, 2023

I meet the same problem. Maybe we should determine the pointer type according the arch of the target

@JBenda
Copy link
Author

JBenda commented Jan 21, 2023

There are already libs to do so, the question is more or less which to use or is ther already a mechanism, but not at this place?

@crunchy234
Copy link

I'm having this same issue on t4g instances in AWS.

@skeet70
Copy link

skeet70 commented Jul 25, 2023

We've also run into this issue building ARM containers that can run on M1/M2 Mac machines. #354 does fix that for us, though then we run into issues building directly on the M1 machine. Not sure if that problem is related or not yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants