fix: keep forwarding Ack & Done & Noop messages #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The patch has been merged as 563e862 Closing as already done. |
|
My bad on closing this without patch been merged. Let me create new PR and continue the work. |
|
Let me reopen this PR and work on it for full context. |
|
@xtexChooser I know it has been 1 year, but could you review new PR at #22 and let me know whether that fit your requirements on wireguard netlink protocol? |
|
Hi! Sorry for my late coming. It seems good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes rust-netlink/netlink-sys#5
I do not know why these packets should be dropped.
In some cases, like WireGuard(rust-netlink/netlink-sys#5 gluxon/wireguard-uapi-rs#28 embeddable-wg-library/wireguard.c#L1185) and nl80211(jbaublitz/neli#134), The request only responses Ack. Without Ack, we can not know whether an operation is done actually.