acpi: fix clippy warnings and run clippy in CI #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
00xc
commented
Nov 22, 2024
•
00xc
commented
- Fix several warnings so that clippy runs cleanly now.
- Add a clippy run on the acpi crate as part of CI.
Running clippy on the ACPI crate returns several warnings about unneeded lifetimes, so remove them.
Place safety documentation in a separate section so that clippy does not emit a warning for them. Add any missing safety documentation as well.
00xc
changed the title
Now that all warnings have been fixed for the acpi crate, run clippy as part of CI. Once the warnings for the rest of the crates are fixed, they can be included in the CI run.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.