Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support or explain usage in Windows console #7

Closed
matthew-a-thomas opened this issue Jul 16, 2019 · 6 comments
Closed

Support or explain usage in Windows console #7

matthew-a-thomas opened this issue Jul 16, 2019 · 6 comments

Comments

@matthew-a-thomas
Copy link
Contributor

In a Windows console you just get garbage like this:

�[48;2;159;114;0m �[0m

Probably need to investigate https://docs.microsoft.com/en-us/windows/console/console-modes

Perhaps this functionality needs to go into another crate (or perhaps someone has already implemented this in another crate)

@matthew-a-thomas matthew-a-thomas changed the title Support Windows console Support or explain usage in Windows console Jul 17, 2019
@matthew-a-thomas
Copy link
Contributor Author

Added short blurb in readme and docs
6565959

@64
Copy link

64 commented Jul 18, 2019

Can you explain why this is in the rust-osdev organisation? Not a criticism, I just don’t see how it’s related

@matthew-a-thomas
Copy link
Contributor Author

@64 Sure: phil-opp/blog_os#603

In summary, Phillip's blog_os does terminal output. This adds colors. None of the other ANSI/terminal color crates support no_std.

I raised this specific issue about Windows consoles because there's nothing about this crate that is environment specific, except that Windows requires additional configuration. I haven't really done anything more than link to MS documentation because I think it's out of the scope of this crate.

Thanks for asking!

@64
Copy link

64 commented Jul 18, 2019

Oh, cool! I think I half expected this to be some kind of state machine for parsing ANSI escape sequences into color info that you can use in VGA textmode (I have that in my kernel). But this also makes sense. Sorry for hijacking the issue, not entirely sure why I decided to do that. Good luck!

@phil-opp
Copy link
Member

Maybe bootimage can set the appropriate console modes on Windows when running/testing a kernel.

@matthew-a-thomas
Copy link
Contributor Author

I'm going to close this because I think the comment in the readme takes care of it. Let me know if I need to open this back up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants