Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to DSTs #132

Closed
phip1611 opened this issue Mar 27, 2023 · 3 comments · Fixed by #134
Closed

Switch to DSTs #132

phip1611 opened this issue Mar 27, 2023 · 3 comments · Fixed by #134
Assignees
@phip1611

Comments

@phip1611
Copy link
Collaborator

After this was discussed in #118 (comment) and #128 (comment), I came to the conclusion, that all such structs should be refactored to DSTs. This will satisfy miri and also cleans up code.
@phip1611 phip1611 self-assigned this Mar 27, 2023
@phip1611
Copy link
Collaborator Author

The feature in Rust is unstable, but luckily, there is https://crates.io/crates/ptr_meta

@YtvwlD
Copy link
Contributor

YtvwlD commented Apr 28, 2023

oh, I've done this in #133 :)

@phip1611 phip1611 mentioned this issue Apr 28, 2023
Merged
@phip1611
Copy link
Collaborator Author

Oh, I did not see this at a first glance. Now we also have #134 😬

@phip1611 phip1611 linked a pull request May 23, 2023 that will close this issue
multiboot2: properly type DST tags #134
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phip1611 phip1611

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

multiboot2: properly type DST tags rust-osdev/multiboot2
2 participants
@YtvwlD @phip1611