-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
investigate generic sample_indicies
#202
Comments
note: it's going to be a little while until I get the chance to dig into this, so if anyone else is interested then have at it! |
Using Using The For completeness, I also tested Floyd's alg (#479) with For conciseness, I think the best approach is to make the Note that I don't think generics are a great option here, since users will often use |
This is related to several comments in #201 and is an extension of the work done as part of #194.
In many cases
sample_indicies
can be au32
or even au16
(u8
is probably not worth it) to save on performance and memory usage. This applies to both thecache
andinplace
implementations. This ticket is to investigate what it would take to make the function generic.This should not be (much of) a breaking change, since in most cases type inference would infer the
usize
requirement. However, it would be a potentially minor one.The text was updated successfully, but these errors were encountered: