Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should BlockRngCore::Results also be AsMut? #376

Closed
pitdicker opened this issue Apr 5, 2018 · 2 comments
Closed

Should BlockRngCore::Results also be AsMut? #376

pitdicker opened this issue Apr 5, 2018 · 2 comments

Comments

@pitdicker
Copy link
Contributor

I think adding the bound now is no big deal, and it could allow for a BlockRng-like implementation that zeros out used results.

On the other hand I don't see much value in modifying / using Results from the 'outside'. Anything that can read the results field of BlockRng can probably also read the internal state of the RNG, so why take extra precautions?
@dhardy
Copy link
Member

dhardy commented Apr 5, 2018

I guess that sounds okay. In any case, BlockRng (or other Rng impl) can govern access to the results field.

@dhardy dhardy mentioned this issue Apr 27, 2018
Closed
33 tasks
@pitdicker pitdicker mentioned this issue Apr 29, 2018
Merged
@dhardy
Copy link
Member

dhardy commented May 8, 2018

Done: #419

@dhardy dhardy closed this as completed May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhardy @pitdicker