Add a note about OsRng blocking in early init.
#134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacwah
suggested changes
Jan 21, 2017
src/os.rs
Outdated
| /// This does not block. | ||
| /// This usually does not block. On some systems (e.g. FreeBSD, OpenBSD, | ||
| /// Max OS X, and modern Linux) this may block very early in the init | ||
| /// process, if the CSPRNG has not seeded yet. |
There was a problem hiding this comment.
Should be "has not been seeded" or "is not seeded".
In my opinion, a source/reference would be great to back this up and provide further reading.
Overall, this is good info to have in the documentation.
There was a problem hiding this comment.
For instance, a link to the PEP metioned in #132 could be useful.
|
I think I've addressed all the comments. |
|
Thanks! |
pitdicker
pushed a commit
to pitdicker/rand
that referenced
this pull request
Apr 4, 2018
Add a note about `OsRng` blocking in early init.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #132.