Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alphanumeric distribution #279

Merged
merged 2 commits into from
Mar 3, 2018
Merged

Add Alphanumeric distribution #279

merged 2 commits into from
Mar 3, 2018

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Mar 3, 2018

Related to #275 but independent (IMO we want this even if we don't merge #275).

@dhardy dhardy mentioned this pull request Mar 3, 2018
3 tasks
@dhardy
Copy link
Member Author

dhardy commented Mar 3, 2018

Test has been running for 45 minutes; cargo install --force cargo-web is very slow here! Caching should be enabled, so maybe it won't always be slow?

Copy link
Contributor

@pitdicker pitdicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pitdicker
Copy link
Contributor

I just wanted to type "sure hope it will become faster, but at least it it still running"... But now Travis gave up (time limit). Do you want to try again? Or leave it for now?

@pitdicker
Copy link
Contributor

@dhardy
Copy link
Member Author

dhardy commented Mar 3, 2018

It still took over 10min.

Looks to me like Cargo needs an update option (cargo install --update cargo-web), because --force forces reinstallation every time.

@dhardy dhardy merged commit 662c68a into rust-random:master Mar 3, 2018
@dhardy dhardy deleted the alpha branch March 3, 2018 13:53
@dhardy dhardy mentioned this pull request Mar 11, 2018
33 tasks
pitdicker pushed a commit that referenced this pull request Apr 4, 2018
Add Alphanumeric distribution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants