Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate MemoryFault exit reason in KVM_RUN #270

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

kalyazin
Copy link
Contributor

@kalyazin kalyazin commented Aug 1, 2024

Summary of the PR

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • [ ] All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • [ ] Any newly added unsafe code is properly documented.

@kalyazin kalyazin force-pushed the memory_fault branch 2 times, most recently from 2c44e58 to a5dfc72 Compare August 1, 2024 11:48
@kalyazin kalyazin marked this pull request as ready for review August 1, 2024 12:44
Copy link
Collaborator

@roypat roypat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nikita :)

src/ioctls/vcpu.rs Outdated Show resolved Hide resolved
src/ioctls/vcpu.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Nikita Kalyazin <kalyazin@amazon.com>
@kalyazin kalyazin force-pushed the memory_fault branch 3 times, most recently from b3f708b to 57bbe01 Compare August 1, 2024 13:32
@kalyazin kalyazin marked this pull request as ready for review August 1, 2024 13:32
roypat
roypat previously approved these changes Aug 1, 2024
src/ioctls/vcpu.rs Outdated Show resolved Hide resolved
src/ioctls/vcpu.rs Outdated Show resolved Hide resolved
Signed-off-by: Nikita Kalyazin <kalyazin@amazon.com>
Signed-off-by: Nikita Kalyazin <kalyazin@amazon.com>
@kalyazin kalyazin requested a review from roypat August 1, 2024 15:28
@roypat roypat merged commit 645533c into rust-vmm:main Aug 1, 2024
19 checks passed
@kalyazin kalyazin deleted the memory_fault branch August 1, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants