-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate MemoryFault exit reason in KVM_RUN #270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalyazin
force-pushed
the
memory_fault
branch
2 times, most recently
from
August 1, 2024 11:48
2c44e58
to
a5dfc72
Compare
kalyazin
requested review from
acatangiu,
alxiord,
andreeaflorescu,
lauralt,
sameo,
roypat and
ShadowCurse
as code owners
August 1, 2024 12:44
roypat
reviewed
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Nikita :)
Signed-off-by: Nikita Kalyazin <kalyazin@amazon.com>
kalyazin
force-pushed
the
memory_fault
branch
3 times, most recently
from
August 1, 2024 13:32
b3f708b
to
57bbe01
Compare
roypat
previously approved these changes
Aug 1, 2024
ShadowCurse
reviewed
Aug 1, 2024
kalyazin
force-pushed
the
memory_fault
branch
2 times, most recently
from
August 1, 2024 15:17
eae3846
to
0aac271
Compare
ShadowCurse
reviewed
Aug 1, 2024
Signed-off-by: Nikita Kalyazin <kalyazin@amazon.com>
Signed-off-by: Nikita Kalyazin <kalyazin@amazon.com>
ShadowCurse
approved these changes
Aug 1, 2024
roypat
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
KVM_CAP_MEMORY_FAULT_INFO
variant toCap
KVM_EXIT_MEMORY_FAULT
exit reason inKVM_RUN
.Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s
), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
[ ] All added/changed functionality has a corresponding unit/integrationtest.
Release" section of CHANGELOG.md (if no such section exists, please create one).
[ ] Any newly addedunsafe
code is properly documented.